This repository was archived by the owner on Jun 29, 2025. It is now read-only.
fix(oauth):add roles support for microsoft oauth#814
Open
AcceisStaff wants to merge 1 commit intostonith404:mainfrom
Open
fix(oauth):add roles support for microsoft oauth#814AcceisStaff wants to merge 1 commit intostonith404:mainfrom
AcceisStaff wants to merge 1 commit intostonith404:mainfrom
Conversation
stonith404
suggested changes
Apr 29, 2025
Owner
stonith404
left a comment
stonith404
left a comment
There was a problem hiding this comment.
Thank you, that's a nice addition. I also like the added dividers!
Please see my comments above and also add the English translations to en-US.ts, because that's the base language.
| .filter( | ||
| (config) => | ||
| config.key.startsWith("oauth.") && | ||
| ![ |
Owner
There was a problem hiding this comment.
Please move the OIDC list into a variable.
| ].some((provider) => config.key.includes(provider)), | ||
| ) | ||
| .map((configVariable) => ( | ||
| <Group key={configVariable.key} position="apart"> |
Owner
There was a problem hiding this comment.
Please move the code for the configuration variables that contains the title, description and input into a separate component. Currently this code is there twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Role-Based Access Control for Microsoft Authentication
What’s New
UI/UX Improvements
usernameClaimroleGeneralAccessroleAdminAccessLet me know if any changes are needed!