This repository was archived by the owner on Jun 29, 2025. It is now read-only.
fix(s3): format path when bucket path is '/'#819
Open
thereis wants to merge 1 commit intostonith404:mainfrom
Open
fix(s3): format path when bucket path is '/'#819thereis wants to merge 1 commit intostonith404:mainfrom
thereis wants to merge 1 commit intostonith404:mainfrom
Conversation
…tions - Added validation for share ID and file name formats in multiple methods to prevent invalid inputs. - Improved error logging for multipart upload failures and file deletion operations. - Added debug logging for key operations, including multipart upload initialization, part uploads, and file deletions. - Ensured consistent error handling by throwing InternalServerErrorException for various failure scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
S3FileServiceclass by improving error handling, adding detailed logging, and validating inputs to ensure robustness and maintainability.When trying the integration of Pingvin with Minio, I had the issue where the bucket content could not be deleted. I've added the path of the bucket as
/, which caused an error in the backend while trying to delete the assets.The error message is also vague, so I added the error object and some debug messages to give a better context of what is happening under the hood:
Error thrown on main when trying to delete the bucket contents on a Minio server.
After cloning and adding the error object to the error message:
{ error: XMinioInvalidObjectName: Object name contains unsupported characters. at throwDefaultError (C:\Projetos\pingvin-share\backend\node_modules\@smithy\smithy-client\dist-cjs\index.js:867:20) at C:\Projetos\pingvin-share\backend\node_modules\@smithy\smithy-client\dist-cjs\index.js:876:5 at de_CommandError (C:\Projetos\pingvin-share\backend\node_modules\@aws-sdk\client-s3\dist-cjs\index.js:4952:14) at process.processTicksAndRejections (node:internal/process/task_queues:105:5) at async C:\Projetos\pingvin-share\backend\node_modules\@smithy\middleware-serde\dist-cjs\index.js:35:20 at async C:\Projetos\pingvin-share\backend\node_modules\@aws-sdk\middleware-sdk-s3\dist-cjs\index.js:484:18 at async C:\Projetos\pingvin-share\backend\node_modules\@smithy\middleware-retry\dist-cjs\index.js:320:38 at async C:\Projetos\pingvin-share\backend\node_modules\@aws-sdk\middleware-sdk-s3\dist-cjs\index.js:110:22 at async C:\Projetos\pingvin-share\backend\node_modules\@aws-sdk\middleware-sdk-s3\dist-cjs\index.js:137:14 at async C:\Projetos\pingvin-share\backend\node_modules\@aws-sdk\middleware-logger\dist-cjs\index.js:33:22 { '$fault': 'client', '$metadata': { httpStatusCode: 400, requestId: '18391315A583A4E6', extendedRequestId: 'dd9025bab4ad464b049177c95eb6ebf374d3b3fd1af9251148b658df7ac2e3e8', cfId: undefined, attempts: 1, totalRetryDelay: 0 }, Code: 'XMinioInvalidObjectName', BucketName: 'mishare', Resource: '/mishare/', Region: 'eu-west', RequestId: '18391315A583A4E6', HostId: 'dd9025bab4ad464b049177c95eb6ebf374d3b3fd1af9251148b658df7ac2e3e8' }, shareId: 'Eo7pQuzW' }Now
When uploading files to a s3 bucket:
When deleting the shared content from pingvin: