Conversation
shilman
reviewed
Jan 31, 2025
Member
shilman
left a comment
shilman
left a comment
There was a problem hiding this comment.
This looks great on first glance. Does it work?
Member
Author
|
@shilman heres the result on this pr beforesort is specified but ignored afterSort specified (note that the order changed) No sort specified |
dannyhw
commented
Jan 31, 2025
| return { index, importMap }; | ||
| const sortableStories = Object.values(index.entries); | ||
|
|
||
| sortStoriesV7( |
Member
Author
There was a problem hiding this comment.
pulling in sort stories from preview api to reuse sorting code
dannyhw
commented
Jan 31, 2025
| options?: ReactNativeOptions; | ||
| }) { | ||
| const { index, importMap } = prepareStories({ storyEntries, options }); | ||
| const composedAnnotations = composeConfigs<ReactRenderer>(annotations); |
Member
Author
There was a problem hiding this comment.
using composeConfig lets us read the parameters synchronously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #414
What I did
figuring out how to apply sorting in v8
How to test
Please explain how to test your changes and consider the following questions
If your answer is yes to any of these, please make sure to include it in your PR.