Skip to content

Increase lowest supported version of Rust to 1.85#1020

Merged
mulkieran merged 1 commit intostratis-storage:masterfrom
mulkieran:issue_project_842
Jan 14, 2026
Merged

Increase lowest supported version of Rust to 1.85#1020
mulkieran merged 1 commit intostratis-storage:masterfrom
mulkieran:issue_project_842

Conversation

@mulkieran
Copy link
Copy Markdown
Member

@mulkieran mulkieran commented Jan 14, 2026

Related stratis-storage/project#842

Summary by CodeRabbit

  • Chores
    • Updated minimum supported Rust version to 1.85.0. Users will need to update their Rust toolchain to build this project.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran added this to the devicemapper-v0.34.7 milestone Jan 14, 2026
@mulkieran mulkieran self-assigned this Jan 14, 2026
@mulkieran mulkieran moved this to In Review in 2026January Jan 14, 2026
@packit-as-a-service
Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-devicemapper-rs-1020
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran
Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 14, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 14, 2026

Walkthrough

The pull request updates the minimum supported Rust version (MSRV) from 1.82.0 to 1.85.0 across CI configuration and package manifests, ensuring consistent version constraints throughout the project.

Changes

Cohort / File(s) Change Summary
CI Workflow Configuration
.github/workflows/main.yml
Updated Rust toolchain version from 1.82.0 to 1.85.0 in two matrix entries: tests-with-sudo and top-level checks
Package Manifests
Cargo.toml, devicemapper-rs-sys/Cargo.toml
Updated rust-version property from "1.82.0" to "1.85.0" in both package metadata sections

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Increase lowest supported version of Rust to 1.85' directly and accurately describes the main change across all modified files (.github/workflows/main.yml, Cargo.toml, and devicemapper-rs-sys/Cargo.toml), which all update the minimum supported Rust version from 1.82.0 to 1.85.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b270ac and cb0d96a.

📒 Files selected for processing (3)
  • .github/workflows/main.yml
  • Cargo.toml
  • devicemapper-rs-sys/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (24)
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
🔇 Additional comments (3)
devicemapper-rs-sys/Cargo.toml (1)

6-6: MSRV update looks correct.

The rust-version is consistently updated to 1.85.0, aligning with the root Cargo.toml and CI workflow changes. The descriptive comment helps maintainability.

.github/workflows/main.yml (1)

64-65: CI matrix correctly updated for MSRV testing.

The lowest supported toolchain is properly updated to 1.85.0 while maintaining the development toolchain at 1.92.0. This ensures the crate is tested against both the minimum and current Rust versions.

Cargo.toml (1)

13-13: MSRV update is consistent across the workspace.

The rust-version bump to 1.85.0 is correctly synchronized across root Cargo.toml, devicemapper-rs-sys/Cargo.toml, and .github/workflows/main.yml. All three locations now consistently declare 1.85.0 as the minimum supported Rust version, which is a valid stable release.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran mulkieran merged commit 97e06e0 into stratis-storage:master Jan 14, 2026
14 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2026January Jan 14, 2026
@mulkieran mulkieran deleted the issue_project_842 branch January 14, 2026 21:53
@mulkieran mulkieran moved this from Done to Done(2) in 2026January Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(2)

Development

Successfully merging this pull request may close these issues.

1 participant