perf: eliminate N+1 Stripe lookups in /products endpoint#378
Open
vincerevu wants to merge 1 commit intostripe:mainfrom
Open
perf: eliminate N+1 Stripe lookups in /products endpoint#378vincerevu wants to merge 1 commit intostripe:mainfrom
vincerevu wants to merge 1 commit intostripe:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves
/productsperformance by removing the N+1 Stripe lookup pattern. Instead of making one Stripe request per product to resolve Stripe-specific IDs, it fetches Stripe products once up front and maps them locally usingmetadata.product_id.What changed
stripe.products.listcallmetadata.product_idto Stripe product IDs/productsflowWhy
Previously, the retrieval loop made one Stripe request for each configured product, so latency scaled linearly with the size of
PRODUCT_CONFIG. This introduced unnecessary network overhead and slower endpoint performance.Measured improvement
The benchmark simulates 5 serial calls to
/products.products.list, completed in 758 msproducts.list, with lower total request overheadImpact
Verification