Adding latest commands from @github/copilot-language-server

[TerminalFi]

Todo

• Ability for changing model in Chat.
• Ability for Edit Conversations
• Ability for Generating Commit Message

[phene]

What's holding up the ability to change models?

[jfcherng]

What's holding up the ability to change models?

#235 should be merged first.

And it has a blocker sublimehq/sublime_text#6424 (not sure whether we can workaround this in ST)

[TerminalFi]

@phene Yes, as @jfcherng stated, while functionality wise this works. When we switch over to the GH provided npm package it is 200+ MB and that causes ST to fail loading the files sadly. There is technically a potential work around, and that is to change how LSP looks for these files :) But I doubt they want to diverge from the build in solution.

The other option is that we can put these new commands behind a setting, and tell the user they must provide the package and update the settings.

I highly encourage you to contribute. It would be greatly appreciated

[jfcherng]

I have update to the latest server with npm install --lockfile-version=2, which is compatible with yarn v1.

[Copilot]

Pull Request Overview

This PR integrates the latest commands and edit-conversation support from the @github/copilot-language-server package.

• Adds edit‐conversation UI, client handlers, and request/notification constants
• Introduces GitHelper and a code‐review request function
• Registers new commands (code review, commit generation, edit conversation, model listing) and updates package.json to use the new server

Reviewed Changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
plugin/ui/init.py	Exported WindowEditConversationManager
plugin/types.py	Added TypedDicts for edit conversations and model definitions
plugin/templates/edit_conversation.md.jinja	New Jinja template for the edit-conversation UI
plugin/helpers.py	Added prepare_code_review_request_doc and GitHelper class
plugin/constants.py	Defined new request and notification constants for edit/chat, context, git, and models
plugin/client.py	Integrated edit‐conversation flow, context provider registration, and new notification handlers
plugin/init.py	Registered new Copilot commands (code review, commit generation, edit conversation, models)
language-server/package.json	Switched dependency to @github/copilot-language-server and bumped version
README.md	Updated documentation links to point at the new language server package
Main.sublime-commands	Added new entries for code review, commit generation, edit conversation, and models
LSP-copilot.sublime-settings	Introduced initializationOptions for future configuration

Files not reviewed (1)

• language-server/package-lock.json: Language not supported

Comments suppressed due to low confidence (6)

plugin/helpers.py:351

• [nitpick] The new GitHelper class and its methods currently lack unit tests. Consider adding tests to cover key behaviors like run_git_command and get_git_changes.

class GitHelper:

plugin/helpers.py:408

• Path is not imported in this module, which will cause a NameError. Add from pathlib import Path to the imports.

                full_path = Path(repo_root) / file_path

Main.sublime-commands:90

• Comments using // are not valid JSON in .sublime-commands files and may break parsing; remove or convert this to a valid JSON field.

        // Debug Command

plugin/client.py:57

• [nitpick] The imports log_info and log_debug are not used in this file; consider removing them to keep imports clean.

from .log import log_warning, log_info, log_debug

plugin/client.py:80

• [nitpick] Imported find_window_by_id is not used anywhere in this module; it can be removed to avoid dead code.

    find_window_by_id,

plugin/templates/edit_conversation.md.jinja:84

• Typo in UI text: Github Copilot should be GitHub Copilot to match correct branding casing.

    <img class="icon" src="{{ asset_url('github.png') }}"> Github Copilot

[jfcherng]

We can ship

• Ability for changing model in Chat
• Ability for Generating Commit Message

and do

• Ability for Edit Conversations

later if someone wants to pick that up.

What do you think @TerminalFi ?

[TerminalFi]

I'm fine with that

[jfcherng]

I think I will just stop here. Leaving "Ability for Edit Conversations" undone.

[jfcherng]

I am considering just merge this PR since there is no ETA for this PR for ALL goals to be done and this PR has existed for 1 year.

[TerminalFi]

I am considering just merge this PR since there is no ETA for this PR for ALL goals to be done and this PR has existed for 1 year.

I'm fine with that. Maybe I will get to this this year 😅😂

[dvernon83]

Can we get this merged? Thanks