Conversation
STReviewBot
left a comment
There was a problem hiding this comment.
Automated testing result: WARNING
Repo link: LSP-wren-lsp
Results help
Packages added:
- LSP-wren-lsp
Processing package "LSP-wren-lsp"
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request. Also consider replacing the platform module with sublime.platform() and sublime.arch().
- File: plugin.py
- Line: 9, Column: 1
I have fixed this issue (thank you for letting me know sublime.platform() is a thing) How do i trigger the automatic check again tho? (i have tagged the new fix as 0.1.0 but nothing happened here) |
STReviewBot
left a comment
There was a problem hiding this comment.
Automated testing result: WARNING
Repo link: LSP-wren-lsp
Results help
Packages added:
- LSP-wren-lsp
Processing package "LSP-wren-lsp"
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 23, Column: 30
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 83, Column: 8
|
Same question as in #144 - would you be willing to move this package to sublimelsp repo? I have various comments and improvements that could be done. |
|
I am. just let me know when the repo is created on sublimelsp. Thanks |
|
Created https://github.com/sublimelsp/LSP-wren-lsp Please ideally create PR against main so that we have a chance to review and make comments. |
|
(accidentally set visibility to private - corrected now) |
STReviewBot
left a comment
There was a problem hiding this comment.
Automated testing result: ERROR
Repo link: LSP-wren-lsp
Results help
Packages added:
- LSP-wren-lsp
Processing package "LSP-wren-lsp"
- ERROR: No valid semver tags found at https://github.com/sublimelsp/LSP-wren-lsp/tags for the package "LSP-wren-lsp".
Thanks. I just did the changes and i have created the PR at sublimelsp/LSP-wren-lsp#1 I didnt tag anything at this time because i think we need to fix the issues on that PR first. |
STReviewBot
left a comment
There was a problem hiding this comment.
Automated testing result: WARNING
Repo link: LSP-wren-lsp
Results help
Packages added:
- LSP-wren-lsp
Processing package "LSP-wren-lsp"
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 30, Column: 30
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 90, Column: 8
|
@rchl i have released a v0.1.0 tag for LSP-wren-lsp, i dont think there is anything blocking us now for this to be merged. |
No description provided.