Skip to content

feat: add wren lsp entry#145

Merged
rchl merged 2 commits intosublimelsp:mainfrom
jossephus:feat/add-wren-lsp
Feb 3, 2026
Merged

feat: add wren lsp entry#145
rchl merged 2 commits intosublimelsp:mainfrom
jossephus:feat/add-wren-lsp

Conversation

@jossephus
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@STReviewBot STReviewBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LSP-wren-lsp
Results help

Packages added:
  - LSP-wren-lsp

Processing package "LSP-wren-lsp"
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request. Also consider replacing the platform module with sublime.platform() and sublime.arch().
    - File: plugin.py
    - Line: 9, Column: 1

@jossephus
Copy link
Copy Markdown
Contributor Author

jossephus commented Feb 2, 2026

Processing package "LSP-wren-lsp"

  • WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request. Also consider replacing the platform module with sublime.platform() and sublime.arch().

I have fixed this issue (thank you for letting me know sublime.platform() is a thing)

How do i trigger the automatic check again tho? (i have tagged the new fix as 0.1.0 but nothing happened here)

@jossephus jossephus requested a review from STReviewBot February 2, 2026 05:59
Copy link
Copy Markdown

@STReviewBot STReviewBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LSP-wren-lsp
Results help

Packages added:
  - LSP-wren-lsp

Processing package "LSP-wren-lsp"
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 23, Column: 30
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 83, Column: 8

@rchl
Copy link
Copy Markdown
Member

rchl commented Feb 2, 2026

Same question as in #144 - would you be willing to move this package to sublimelsp repo? I have various comments and improvements that could be done.

@jossephus
Copy link
Copy Markdown
Contributor Author

I am. just let me know when the repo is created on sublimelsp. Thanks

@rchl
Copy link
Copy Markdown
Member

rchl commented Feb 2, 2026

Created https://github.com/sublimelsp/LSP-wren-lsp

Please ideally create PR against main so that we have a chance to review and make comments.

@rchl
Copy link
Copy Markdown
Member

rchl commented Feb 2, 2026

(accidentally set visibility to private - corrected now)

Copy link
Copy Markdown

@STReviewBot STReviewBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: LSP-wren-lsp
Results help

Packages added:
  - LSP-wren-lsp

Processing package "LSP-wren-lsp"
  - ERROR: No valid semver tags found at https://github.com/sublimelsp/LSP-wren-lsp/tags for the package "LSP-wren-lsp".

@jossephus
Copy link
Copy Markdown
Contributor Author

jossephus commented Feb 2, 2026

Created https://github.com/sublimelsp/LSP-wren-lsp

Please ideally create PR against main so that we have a chance to review and make comments.

Thanks.

I just did the changes and i have created the PR at sublimelsp/LSP-wren-lsp#1

I didnt tag anything at this time because i think we need to fix the issues on that PR first.

@jossephus jossephus requested a review from STReviewBot February 3, 2026 18:30
Copy link
Copy Markdown

@STReviewBot STReviewBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LSP-wren-lsp
Results help

Packages added:
  - LSP-wren-lsp

Processing package "LSP-wren-lsp"
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 30, Column: 30
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 90, Column: 8

@jossephus
Copy link
Copy Markdown
Contributor Author

@rchl i have released a v0.1.0 tag for LSP-wren-lsp, i dont think there is anything blocking us now for this to be merged.

@rchl rchl merged commit b41180c into sublimelsp:main Feb 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants