Skip to content

fix: don't mask errors with a "header is already set" error when rendering the error page#16323

Open
Nic-Polumeyv wants to merge 1 commit into
sveltejs:mainfrom
Nic-Polumeyv:fix-error-page-setheaders
Open

fix: don't mask errors with a "header is already set" error when rendering the error page#16323
Nic-Polumeyv wants to merge 1 commit into
sveltejs:mainfrom
Nic-Polumeyv:fix-error-page-setheaders

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

If the root layout load calls setHeaders and something throws while the page renders, the error page dies too. respond_with_error re-runs the root layout load on the same event, so the second setHeaders call hits the set-once check and throws "cache-control" header is already set. That error replaces the real one in handle_error_and_jsonify, so the log shows only the setHeaders complaint and the response falls back to the static error page instead of +error.svelte.

The set-once throw is by design (#5778), so it stays for normal rendering. The fix skips duplicate keys only while the error page renders (state.error), keeping the value from the original render. Same load, same request, so the values are identical anyway. #14681 already carved server-timing out of this throw.

load errors take the nearest-boundary path without re-running the root layout, so the test throws during SSR render instead. The basics root layout sets the header only for the test route (existing locals.url pattern), keeping every other test response unchanged. Fails on main, passes with the fix, in both dev and build.

The server-timing append would double up during the re-run. That predates this change, so I left it.

Fixes #11676


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 5767856:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/5767856a7c6f50253ce3c79fe355e0c17fdfd639

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16323

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5767856

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect "Cache-Control" Error Message in SvelteKit when Protected Route has Import Issue

1 participant