Revert "Avoid hanging trying to diff Data and similar collections. (#1644)"#1662
Merged
stmontgomery merged 1 commit intoswiftlang:mainfrom Apr 4, 2026
Merged
Conversation
…wiftlang#1644)" This reverts commit 862937a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the change recently made in #1644. It ended up causing slow type-checking of certain complex expressions passed to
#expect, such as this one in particular in the swift-build project:It appears the new
__checkBinaryOperation()overload added in that PR caused type-checking to become more complex and slower for complex expressions such as this. It may be possible to implement an alternate approach for this which checks the type at runtime only, to avoid needing an additional overload.Related to: rdar://173002947
Checklist: