Allow 'auto' to be passed as a height#2133
Open
Whatshiywl wants to merge 1 commit intoswimlane:masterfrom
Open
Allow 'auto' to be passed as a height#2133Whatshiywl wants to merge 1 commit intoswimlane:masterfrom
Whatshiywl wants to merge 1 commit intoswimlane:masterfrom
Conversation
achimha
suggested changes
May 7, 2023
Contributor
achimha
left a comment
achimha
left a comment
There was a problem hiding this comment.
if headerHeight/footerHeight is 'auto', the calculation with height = height - (this.footerHeight as number) will not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The headerHeight and footerHeight inputs of
ngx-datatableaccept the 'auto' value as well as numbers, going as far as verifying if their values match that specific string. However, their current type signature allows for numbers only. This type conflict pops up when usingstrictTemplatesas an Angular Compiler Option.What is the new behavior?
The two aforementioned inputs will now allow the 'auto' value to be passed without incurring in build errors when template type checking is enabled.
Does this PR introduce a breaking change? (check one with "x")