refactor(footer): removed irrelevant inputs#2169
Open
chintankavathia wants to merge 1 commit intoswimlane:masterfrom
Open
refactor(footer): removed irrelevant inputs#2169chintankavathia wants to merge 1 commit intoswimlane:masterfrom
chintankavathia wants to merge 1 commit intoswimlane:masterfrom
Conversation
Removed @inputs which are not relevant and has no effect at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed @inputs which are not relevant and has no effect at all.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
certain @inputs in
<ngx-datatable-footer>for custom footer has no meaning doesn't do anything.What is the new behavior?
Removed such @inputs which are not relevant.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: