Add TensorYlm filter to GH and CSW evolutions#7041
Open
nilsvu wants to merge 9 commits intosxs-collaboration:developfrom
Open
Add TensorYlm filter to GH and CSW evolutions#7041nilsvu wants to merge 9 commits intosxs-collaboration:developfrom
nilsvu wants to merge 9 commits intosxs-collaboration:developfrom
Conversation
fa1644c to
a577f61
Compare
fc39259 to
7df57cb
Compare
Member
Author
|
@kidder @nilsdeppe @wthrowe I switched to a base class implementation (only last commit changed). Let me know what you think! |
8d38392 to
6003038
Compare
afc1b97 to
2fb0707
Compare
Member
Author
|
Rebased on #7112 , so this PR should enable spherical shell filtering now. |
Adds a base class for filters and makes filters option-creatable. Stores them in the DataBox so they can have caches.
Otherwise we get name collisions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some cleanup of TensorYlm code, then adds GH and CSW TensorYlm filtering actions with caching. Last 3 commits are tiny improvements I found when trying to run spherical shells.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments