Skip to content

Add TensorYlm filter to GH and CSW evolutions#7041

Open
nilsvu wants to merge 9 commits intosxs-collaboration:developfrom
nilsvu:ylm_filter
Open

Add TensorYlm filter to GH and CSW evolutions#7041
nilsvu wants to merge 9 commits intosxs-collaboration:developfrom
nilsvu:ylm_filter

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Jan 27, 2026

Proposed changes

Some cleanup of TensorYlm code, then adds GH and CSW TensorYlm filtering actions with caching. Last 3 commits are tiny improvements I found when trying to run spherical shells.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu force-pushed the ylm_filter branch 2 times, most recently from fa1644c to a577f61 Compare March 5, 2026 00:10
@nilsvu nilsvu marked this pull request as ready for review March 5, 2026 00:16
@nilsvu nilsvu requested review from markscheel and nilsdeppe March 5, 2026 00:17
@nilsvu nilsvu force-pushed the ylm_filter branch 7 times, most recently from fc39259 to 7df57cb Compare March 10, 2026 00:26
@nilsvu
Copy link
Member Author

nilsvu commented Mar 10, 2026

@kidder @nilsdeppe @wthrowe I switched to a base class implementation (only last commit changed). Let me know what you think!

@nilsvu nilsvu force-pushed the ylm_filter branch 4 times, most recently from 8d38392 to 6003038 Compare March 10, 2026 21:48
@nilsvu nilsvu changed the title Add TensorYlm filter to GH evolution Add TensorYlm filter to GH and CSW evolutions Mar 10, 2026
@nilsvu nilsvu force-pushed the ylm_filter branch 4 times, most recently from afc1b97 to 2fb0707 Compare March 11, 2026 22:37
@nilsvu
Copy link
Member Author

nilsvu commented Mar 11, 2026

Rebased on #7112 , so this PR should enable spherical shell filtering now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant