Skip to content

Fix cuda-13 compiler errors#7063

Open
nikwit wants to merge 1 commit intosxs-collaboration:developfrom
nikwit:fix-nvcc
Open

Fix cuda-13 compiler errors#7063
nikwit wants to merge 1 commit intosxs-collaboration:developfrom
nikwit:fix-nvcc

Conversation

@nikwit
Copy link
Contributor

@nikwit nikwit commented Feb 11, 2026

Proposed changes

These changes were needed to compile spectre on anta with the nvcc of cuda-13.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

namespace Options {
namespace detail {
namespace {
void check_metadata(const YAML::Node& metadata);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this change needed?

if (info.format != py::format_descriptor<double>::format()) {
throw std::runtime_error(
"Incompatible format: expected a double array.");
throw std::runtime_error{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be fixed with 2871a1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants