Merged
Conversation
behrmann
reviewed
Mar 2, 2026
Contributor
behrmann
left a comment
behrmann
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
pothos
force-pushed
the
logprefix
branch
3 times, most recently
from
094c366 to
4832585
Compare
Contributor
Author
|
Had to rebase but since I moved the IMAGE.set to the build_image function I wanted to test again but ran into some other issue with latest main. |
Contributor
Author
|
Should be good now |
behrmann
approved these changes
Mar 4, 2026
Contributor
behrmann
left a comment
behrmann
left a comment
There was a problem hiding this comment.
I really like this, just scrolled the CI logs and this does improve orientation quite a bit.
daandemeyer
reviewed
Mar 16, 2026
mkosi/config.py
Outdated
| default=False, | ||
| ) | ||
| parser.add_argument( | ||
| "--log-timing", |
Contributor
There was a problem hiding this comment.
Let's name this --debug-perf or --debug-timing or so?
Contributor
There was a problem hiding this comment.
Needs to be added to the man page as well
Contributor
Author
There was a problem hiding this comment.
Thanks! Went with debug-timing.
daandemeyer
requested changes
Mar 16, 2026
mkosi/config.py
Outdated
| default=False, | ||
| ) | ||
| parser.add_argument( | ||
| "--log-timing", |
Contributor
There was a problem hiding this comment.
Needs to be added to the man page as well
Currently it's not really easy to know which log output belongs to which mkosi image when there's the tools tree image, the main image, and any sub images. Add a log prefix that remembers the current image so that it's not just "‣ Installing Fedora Linux" but "‣ [tools] Installing Fedora Linux", "‣ [default-initrd] Installing Fedora Linux", and "‣ [main] Installing Fedora Linux".
The printing of the duration for each step was behind the --debug flag which adds more noise when one is just interested in the build times. Also, the printing of the step duration serves as good marker during log reading to understand where the above log output belongs to. Add a new --debug-timing flag to always print the step durations.
daandemeyer
approved these changes
Mar 16, 2026
behrmann
added
good-to-merge/waiting-for-ci
and removed
good-to-merge/with-minor-suggestions
labels
behrmann
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add context to log output
Currently it's not really easy to know which log output belongs to which
mkosi image when there's the tools tree image, the main image, and any
sub images.
Add a log prefix that remembers the current image so that it's not just
"‣ Installing Fedora Linux" but "‣ [tools] Installing Fedora Linux",
"‣ [default-initrd] Installing Fedora Linux", and
"‣ [main] Installing Fedora Linux".
Allow printing of step durations with CLI flag
The printing of the duration for each step was behind the --debug flag
which adds more noise when one is just interested in the build times.
Also, the printing of the step duration serves as good marker during
log reading to understand where the above log output belongs to.
Add a new --log-timing flag to always print the step durations.
I first thought about prefixing all output lines but with the two changes above it works well enough to frame long output. Prefixing all output including the scripts would mean to emulate a TTY so that colors and so on would still be used. That could be a good idea as well if one needs timestamps for every line but I think that would be something for another PR.