Make e2e tests cleaner and self-debugging#366
Merged
jacalata merged 9 commits intodevelopmentfrom Oct 10, 2025
Merged
Conversation
Contributor
jacalata
commented
Oct 8, 2025
- Added initial tests that report if expected assets are not present
- Made the suite fail early if publishing fails (because everything else depends on that)
- Made the filenames unique per run so that re-runs are not affected by earlier passes
- Broke up the test file into classes to separate setup and tests
- change test asset names - make a more reliable way to get unique publishing names for reliability - fix option for -d in extract refresh command
Make tests use new unique names each time, so that re-runs pass.
There was a problem hiding this comment.
Pull Request Overview
Refactored e2e tests to improve debugging capabilities and test reliability by restructuring test files into separate classes, adding asset validation, implementing unique naming for test runs, and ensuring early failure on publishing issues.
- Reorganized test structure by separating
TabcmdCallutility methods fromOnlineCommandTesttest cases - Added initial asset file validation and unique filename generation per test run
- Implemented early failure mechanism for publishing operations since subsequent tests depend on them
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/e2e/tests_integration.py | Added logger initialization to test methods |
| tests/e2e/online_tests.py | Major refactoring: created TestAssets and TabcmdCall classes, added asset validation, implemented unique naming |
| tests/assets/live_mysql.tds | Added new test asset file containing MySQL datasource configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
anyoung-tableau
approved these changes
Oct 9, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.