Closed
Conversation
anyoung-tableau
commented
Mar 18, 2026
| withTrace, | ||
| } from '@openai/agents'; | ||
| import { OpenAI } from 'openai/client.js'; | ||
| import OpenAI from 'openai'; |
Collaborator
Author
There was a problem hiding this comment.
The TypeScript compiler was complaining about this line with the module resolution changes.
anyoung-tableau
commented
Mar 18, 2026
| @@ -0,0 +1,13 @@ | |||
| import { BuildConfiguration, isBuildConfiguration } from './scripts/buildConfigurations'; | |||
|
|
|||
| class MetaEnv { | |||
Collaborator
Author
There was a problem hiding this comment.
This abstraction isn't really necessary, but I prefer the type-safety it provides, rather than just cluttering the code and referencing import.meta.env.BUILD_CONFIGURATION everywhere.
anyoung-tableau
commented
Mar 18, 2026
Comment on lines
+4
to
+6
| "module": "ESNext", | ||
| "moduleResolution": "bundler", | ||
| "noEmit": true, |
Collaborator
Author
There was a problem hiding this comment.
These changes are to get tsc to stop complaining about the use of import.meta.env. We're only using tsc for type-checking anyway so threw in noEmit for good measure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build now emits TWO files.
The original index.js (with
import.meta.env.BUILD_CONFIGURATIONreplaced with "default")A new index-experimental.js file (with
import.meta.env.BUILD_CONFIGURATIONreplaced with "experimental")