fix: retry openai server errors - #3851
Closed
amitksingh1490 wants to merge 1 commit into
Closed
Conversation
Co-authored-by: ForgeCode <noreply@forgecode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat OpenAI
server_errorresponses as retryable alongside overloaded-server responses, while expanding unit coverage for release, configuration, domain, and retry behavior.Changes
server_is_overloadedandserver_erroras transient OpenAI failurespretty_assertionsfor clearer assertion output in the affected cratesKey Implementation Details
OpenAI retryable error codes are consolidated into a shared constant used by the provider error classifier. Other API error codes, including
rate_limit, remain non-retryable through this classification path.Testing
Exercise the unit tests added or updated in:
crates/forge_ci/src/release_matrix.rscrates/forge_config/src/decimal.rscrates/forge_domain/src/file.rscrates/forge_domain/src/model.rscrates/forge_eventsource/src/retry.rscrates/forge_repo/src/provider/retry.rs