feat(sdk): use TailorErrors for resolver input validation#805
Draft
feat(sdk): use TailorErrors for resolver input validation#805
Conversation
Replace generic Error with TailorErrors in resolver input validation so that the PF runtime can expand validation issues into individual GraphQL errors with field-level paths.
🦋 Changeset detectedLatest commit: af4ee05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Code Metrics Report (packages/sdk)
Details | | main (08b4d38) | #805 (1e7ee12) | +/- |
|--------------------|----------------|----------------|-------|
+ | Coverage | 55.8% | 55.8% | +0.0% |
| Files | 324 | 324 | 0 |
| Lines | 10320 | 10324 | +4 |
+ | Covered | 5764 | 5768 | +4 |
+ | Code to Test Ratio | 1:0.4 | 1:0.4 | +0.0 |
| Code | 61615 | 61651 | +36 |
+ | Test | 24673 | 24696 | +23 |Code coverage of files in pull request scope (74.7% → 75.7%)
SDK Configure Bundle Size
Runtime Performance
Type Performance (instantiations)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Errorwith PF runtime'sTailorErrorsin resolver input validation (both production bundler and test-run bundler)patharrays (e.g.["a"]), enabling the PF to expand them into individual GraphQL errorssetupTailorErrorsMock()test utility to mock the PF runtime'sTailorErrorsglobal