Skip to content

Conversation

@barnstar
Copy link
Member

@barnstar barnstar commented Apr 24, 2025

updates tailscale/tailscale#13937

This adds localAPI support into TailscaleKit. LocalAPI can now be queried via the SOCK5 proxy on both MacOS and iOS. This also fixes SOCKS5 support generally for iOS so you can simply apply our config to a URLSession.

This pulls in most of LocalAPI - though much of it is untested, it's based on the implementation in tailscale/corp/xcode.

Unit tests and documentation are notably missing - and pending.

Also updated to tailscale v1.82.5

@barnstar barnstar requested review from danderson and oxtoacart April 24, 2025 20:40
@ghost
Copy link

ghost commented Apr 24, 2025

Pull Request Revisions

RevisionDescription
r4
Removed NSLog debug statementDeleted an NSLog debugging line in the removePeersHandler method that printed "Bye Bye Netmap"
r3
Removed platform-specific proxy configurationConsolidated platform-specific proxy configuration into a single implementation, adding HTTPS proxy enablement for both macOS and iOS
r2
Refactored TailscaleKit Swift typesSignificant restructuring of TailscaleKit Swift types with naming convention changes, type simplification, and removal of some unnecessary code
r1
Updated module dependencies and codeUpgraded Go module dependencies to latest versions, added several new Swift files for LocalAPI support, and made various improvements to TailscaleKit implementation, including better iOS support and error handling

✅ AI review completed for r4
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@barnstar barnstar changed the title swift, go.mod: adding localAPI support via SOCK5 swift, go.mod: add localAPI support Apr 24, 2025
@barnstar barnstar force-pushed the barnstar/swift-bindings branch from 3650ff9 to 33db56d Compare April 25, 2025 15:35
@barnstar barnstar force-pushed the barnstar/swift-bindings branch from 33db56d to 145f002 Compare April 25, 2025 15:46
updates tailscale/tailscale#13937

This adds localAPI support into TailscaleKit.  LocalAPI can now be queried
via the SOCK5 proxy on both MacOS and iOS.   This also fixes SOCKS5
support for iOS so you can simply apply our config to a URLSession.

This pulls in most of LocalAPI - though much of it is untested, it's based
on the implementation in tailscale/corp/xcode.

Unit tests pending.

Signed-off-by: Jonathan Nobels <[email protected]>
@barnstar barnstar force-pushed the barnstar/swift-bindings branch from 145f002 to d8f65c0 Compare April 25, 2025 15:52
@barnstar barnstar merged commit d5a3c8e into main Apr 25, 2025
3 of 4 checks passed
@barnstar barnstar deleted the barnstar/swift-bindings branch April 28, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants