swift: remove signing from TailscaleKit framework builds#35
Merged
Conversation
updates tailscale/tailscale#15802 make ios and make macos for TailscaleKit should build unsigned frameworks. This also removes the kCFNetworkProxiesHTTPSEnable flag for iOS which is not available. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
Pull Request Revisions
✅ AI review completed for r1 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at team@review.ai. |
ghost
reviewed
Apr 28, 2025
Comment on lines
+32
to
+34
| #if os(macOS) | ||
| config[kCFNetworkProxiesHTTPSEnable] = true | ||
| #endif |
There was a problem hiding this comment.
In swift/TailscaleKit/URLSession+Tailscale.swift, the HTTPS proxy enablement is now conditionally applied only on macOS. Did you verify that excluding the HTTPS enable flag on iOS doesn't affect HTTP connections that upgrade to HTTPS?
bradfitz
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates tailscale/tailscale#15802
"make ios" and "make macos" for TailscaleKit should produce unsigned frameworks. Auto-signing turned off in xCode as well.
This also removes the kCFNetworkProxiesHTTPSEnable flag for iOS which is not available.
Sample builds and runs as expected. Tests pass. These are still signed by Tailscale (and will have to be changed if somebody wants to run them).