refactor(tests): Hide bitcoind stopper#261
Open
mariocynicys wants to merge 4 commits intotalaia-labs:masterfrom
Open
refactor(tests): Hide bitcoind stopper#261mariocynicys wants to merge 4 commits intotalaia-labs:masterfrom
mariocynicys wants to merge 4 commits intotalaia-labs:masterfrom
Conversation
this avoids having exiplict handling of the bitcoind stopper and it being all over the place when the carrier (by the end of the test) the stopper will get dropped as well which will cause the mock server to shutdown
In some tests the carrier didn't need a stopper since it was already in the test scope so it would drop at the end of the test and do usual cleanup. This commit unifies stuff and still moves the stopper inside the carrier so that all the tests look alike (not having ones with Some(stopper) and ones with None).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had to assign the stopper to a variable in the tests so to have it dropped at the end of the test and clean up the spawned mock server.
This refactor makes it so that the stopper is stored in
Carrier(but only on test mode) and it's dropped whenever the carrier is dropped. I chose to include it in the carrier since the carrier is the struct that talks with bitcoind, so if the carrier is to die so should bitcoind as well.