Skip to content

fix: add g++ to the base-builder dependencies in DockerfileTDgpt.base#34546

Open
tomchon wants to merge 6 commits intomainfrom
enh/add-tdgpt-docker-gplus
Open

fix: add g++ to the base-builder dependencies in DockerfileTDgpt.base#34546
tomchon wants to merge 6 commits intomainfrom
enh/add-tdgpt-docker-gplus

Conversation

@tomchon
Copy link
Contributor

@tomchon tomchon commented Feb 10, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 10, 2026 04:41
@tomchon tomchon requested a review from feici02 as a code owner February 10, 2026 04:41
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tomchon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build dependency by incorporating the g++ compiler into the base-builder stage of the Docker image. This ensures that any subsequent build steps requiring C++ compilation will have the necessary tools available, preventing potential build failures.

Highlights

  • Dockerfile Dependency: Added g++ to the apt-get install command in DockerfileTDgpt.base to ensure C++ compilation capabilities are available in the base-builder stage.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • packaging/docker/DockerfileTDgpt.base
    • Added g++ to the list of packages installed during the apt-get install command.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the C++ compiler to the Docker “base-builder” stage so Python dependencies with native C/C++ extensions can build successfully during image creation.

Changes:

  • Install g++ alongside gcc in the base-builder apt dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds g++ to the build dependencies in DockerfileTDgpt.base to support the compilation of Python packages with C++ extensions. I've provided a suggestion to further improve this by using the build-essential meta-package, which is a more robust and idiomatic approach for installing build-time dependencies in a Dockerfile.

ARG ARCH=amd64
RUN apt-get -o Acquire::Check-Valid-Until=false -o Acquire::Check-Date=false update -y && \
apt-get install -y --no-install-recommends gcc libc-dev procps && \
apt-get install -y --no-install-recommends gcc g++ libc-dev procps && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and to ensure all common build tools are present, it's recommended to use the build-essential meta-package instead of listing gcc and g++ individually. The build-essential package includes gcc, g++, make, and other necessary build tools (like libc-dev), making the build stage more robust for Python packages that might have varied native extension build requirements.

    apt-get install -y --no-install-recommends build-essential procps && \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant