Use specific URL for the reload web socket#322
Open
garyb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using
live-serverto serve static files and then have it proxying an API also, that API has a web socket endpoint, but it's unreachable at the moment as any web socket connection attempts made to thelive-serverwill be grabbed by the reload socket.This PR gives the reload socket endpoint in the injected code a slightly less generic name (in the hopes of avoiding potential overlaps) and adds a check to only connect the reload handling stuff if the request matches the name, allowing middleware or other things to pick up other socket requests as necessary.