Skip to content

fix(cli): allow build --bundles nsis arg in linux+macOS#14954

Merged
FabianLars merged 8 commits intotauri-apps:devfrom
everzoo:allow-nsis-bundling-linux
Mar 17, 2026
Merged

fix(cli): allow build --bundles nsis arg in linux+macOS#14954
FabianLars merged 8 commits intotauri-apps:devfrom
everzoo:allow-nsis-bundling-linux

Conversation

@acx0
Copy link
Contributor

@acx0 acx0 commented Feb 16, 2026

Allow nsis value to be passed as arg to build subcommand when cross-compiling windows binaries on linux hosts.

This was discussed way back in #13943 but I hadn't gotten around to implementing it since omitting the --bundles flag when invoking pnpm tauri build --target x86_64-pc-windows-msvc --runner cargo-xwin would just result in both MSI and NSIS bundles being produced (with MSI bundling being a no-op on linux hosts).

This needs to be explicitly allowed now since #14521 gated the windows bundling logic behind #[cfg(target_os = "windows")].

@acx0 acx0 requested a review from a team as a code owner February 16, 2026 05:47
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Feb 16, 2026
@FabianLars
Copy link
Member

thanks for the PR! nsis builds can be built on macOS as well so this needs a little bit more thinking. I'm only on my phone right now so can't help much but let me know if you need help and i'll get back to you when i can :)

@acx0
Copy link
Contributor Author

acx0 commented Feb 16, 2026

No worries, I can try setting up cross-compilation in macOS and update the PR

@acx0
Copy link
Contributor Author

acx0 commented Feb 16, 2026

@FabianLars was able to produce a working NSIS exe in macOS by just extending the cfg-guard in ...bundle/settings.rs:

[i] sentinowl@XXXXXX:sentinowl-desktop (br:main) (st:1) $ ~/oss/tauri/target/debug/cargo-tauri build --target x86_64-pc-windows-msvc --runner cargo-xwin --bundles nsis -- --bin sentinowl --features gui
...
   Compiling sentinowl v0.9.3 (/Users/sentinowl/src/sentinowl-desktop/core)
    Finished `release` profile [optimized] target(s) in 33.23s
       Built application at: /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe
        Warn Cross-platform compilation is experimental and does not support all features. Please use a matching host system for full compatibility.
        Warn Signing, by default, is only supported on Windows hosts, but you can specify a custom signing command in `bundler > windows > sign_command`, for now, skipping signing the installer...
        Info Target: x64
     Running makensis to produce /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.9.3_x64-setup.exe
warning 5202: -OUTPUTCHARSET is disabled for non Win32 platforms.
        Warn Signing, by default, is only supported on Windows hosts, but you can specify a custom signing command in `bundler > windows > sign_command`, for now, skipping signing the installer...
    Bundling /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.9.3_x64-setup.nsis.zip
        Warn Legacy v1 compatible updater is deprecated and will be removed in v3, change bundle > createUpdaterArtifacts to true when your users are updated to the version with v2 updater plugin
    Finished 1 bundle at:
        /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.9.3_x64-setup.exe
        /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.9.3_x64-setup.nsis.zip (updater)

    Finished 2 updater signatures at:
        /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.9.3_x64-setup.exe.sig
        /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.9.3_x64-setup.nsis.zip.sig

[i] sentinowl@XXXXXX:sentinowl-desktop (br:main) (st:1) $ sw_vers
ProductName:            macOS
ProductVersion:         15.6.1
BuildVersion:           24G90

@acx0 acx0 changed the title fix(cli): allow build --bundles nsis arg in linux fix(cli): allow build --bundles nsis arg in linux+macOS Feb 16, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

Package Changes Through e02c76a

There are 5 changes which include tauri-macos-sign with patch, tauri with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-macos-sign 2.3.3 2.3.4
tauri-bundler 2.8.1 2.8.2
tauri 2.10.3 2.11.0
@tauri-apps/cli 2.10.1 2.10.2
tauri-cli 2.10.1 2.10.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@acx0
Copy link
Contributor Author

acx0 commented Feb 20, 2026

@FabianLars let me know if you need me to verify/test anything else or if this approach is sufficient for now, thanks!

@acx0 acx0 force-pushed the allow-nsis-bundling-linux branch from 268ca4e to 413729e Compare February 27, 2026 21:17
@acx0 acx0 force-pushed the allow-nsis-bundling-linux branch from 413729e to 8e69607 Compare March 11, 2026 16:14
#[cfg(target_os = "windows")]
PackageType::WindowsMsi,
#[cfg(target_os = "windows")]
#[cfg(any(target_os = "windows", target_os = "linux", target_os = "macos"))]
Copy link
Member

@FabianLars FabianLars Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[cfg(any(target_os = "windows", target_os = "linux", target_os = "macos"))]
// NSIS installers can be built on all platforms but it's hidden in the --help output on macOS/Linux.

mobile etc aren't a concern here so we can just remove the cfg, same as the Updater variant below

@FabianLars
Copy link
Member

i cannot push to your branch, can you change line 46 in bundle.rs to this?

let hide = (!cfg!(windows) && self.0 == PackageType::Nsis) || self.0 == PackageType::Updater;

This should hide the nsis bundle from the help output on linux/macos cause it looks kinda weird imo and may be confusing to those not knowing that nsis is windows only

@acx0 acx0 requested a review from FabianLars March 12, 2026 16:30
FabianLars
FabianLars previously approved these changes Mar 14, 2026
@FabianLars
Copy link
Member

FabianLars commented Mar 14, 2026

Sorry for the super slow feedback loop! I don't have my mac machine with me to test but according to the code and the logs you shared the bundle_type is not patched into the binary which we need for proper updater support.

If you want to take a look that'd be appreciated, otherwise i'll have my macbook again next week :)

@acx0
Copy link
Contributor Author

acx0 commented Mar 14, 2026

No worries, I'll try taking a look when I get a chance

@acx0
Copy link
Contributor Author

acx0 commented Mar 16, 2026

@FabianLars looks like the patching flow is being performed now with the latest changes:

build output from macos host + cargo-xwin (without binary signing):

    Finished `release` profile [optimized] target(s) in 1m 25s
       Built application at: /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe
        Warn Cross-platform compilation is experimental and does not support all features. Please use a matching host system for full compatibility.
        Warn Signing, by default, is only supported on Windows hosts, but you can specify a custom signing command in `bundler > windows > sign_command`, for now, skipping signing the installer...
        Info Patching /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe with bundle type information: nsis
        Info Target: x64
     Running makensis to produce /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe
warning 5202: -OUTPUTCHARSET is disabled for non Win32 platforms.
        Warn Signing, by default, is only supported on Windows hosts, but you can specify a custom signing command in `bundler > windows > sign_command`, for now, skipping signing the installer...
    Finished 1 bundle at:
        /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe

    Finished 1 updater signature at:
        /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe.sig

for comparison, build output from linux host + cargo-xwin (with binary signing):

    Finished `release` profile [optimized] target(s) in 1m 05s
       Built application at: /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe
        Warn Cross-platform compilation is experimental and does not support all features. Please use a matching host system for full compatibility.
     Signing ../../build-artifacts/smartmontools/smartctl-x86_64-pc-windows-msvc.exe
     Signing ../../build-artifacts/smartmontools/smartctl-x86_64-pc-windows-msvc.exe with a custom signing command
     Signing Output of signing command:
skipping signing of smartctl binary [../../build-artifacts/smartmontools/smartctl-x86_64-pc-windows-msvc.exe]
        Info Patching /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe with bundle type information: nsis
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe with a custom signing command
     Signing Output of signing command:
Adding Authenticode signature to /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe
        Info Target: x64
        Info Signing NSIS plugins
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/NSISdl.dll
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/NSISdl.dll with a custom signing command
     Signing Output of signing command:
skipping signing of dll [/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/NSISdl.dll]
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/StartMenu.dll
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/StartMenu.dll with a custom signing command
     Signing Output of signing command:
skipping signing of dll [/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/StartMenu.dll]
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/System.dll
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/System.dll with a custom signing command
     Signing Output of signing command:
skipping signing of dll [/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/System.dll]
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/nsDialogs.dll
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/nsDialogs.dll with a custom signing command
     Signing Output of signing command:
skipping signing of dll [/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/nsDialogs.dll]
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/additional/nsis_tauri_utils.dll
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/additional/nsis_tauri_utils.dll with a custom signing command
     Signing Output of signing command:
skipping signing of dll [/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/additional/nsis_tauri_utils.dll]
     Running makensis to produce /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe
warning 5202: -OUTPUTCHARSET is disabled for non Win32 platforms.
Adding Authenticode signature to /tmp/makensiscETdje
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe with a custom signing command
     Signing Output of signing command:
Adding Authenticode signature to /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe
    Finished 1 bundle at:
        /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe

    Finished 1 updater signature at:
        /home/sam/var/cargo-build/sentinowl/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe.sig

@acx0 acx0 requested a review from FabianLars March 16, 2026 16:37
// NSIS installers can be built in macOS using cargo-xwin
crate::PackageType::Nsis => b"__TAURI_BUNDLE_TYPE_VAR_NSS",
_ => {
return Err(crate::Error::InvalidPackageType(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test it but i think this will return an error when you're building for macos on macos now. I think we still should not patch these binaries but we could return Ok(()) in these cases. Just wondering if that should happen at the top of the function so we don't print the "Patchin x with bundle type information" stuff 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops yeah it emitted a warning about but still but continued with the rest of the bundling process since patching is best-effort:

    if let Err(e) = patch_binary(&main_binary_path, package_type) {
      log::warn!("Failed to add bundler type to the binary: {e}. Updater plugin may not be able to update this package. This shouldn't normally happen, please report it to https://github.com/tauri-apps/tauri/issues");
    }

I moved things around a bit, lmk what you think

macos native bundle:

    Finished `release` profile [optimized] target(s) in 32.46s
       Built application at: /Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/sentinowl
    Bundling Sentinowl.app (/Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app)
     Signing with identity "M4DQ8GQP99"
Signing with identity "M4DQ8GQP99"
Signing /Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app/Contents/MacOS/smartctl
/Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app/Contents/MacOS/smartctl: replacing existing signature
Signing with identity "M4DQ8GQP99"
Signing /Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app/Contents/MacOS/sentinowl
/Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app/Contents/MacOS/sentinowl: replacing existing signature
Signing with identity "M4DQ8GQP99"
Signing /Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app
/Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app: replacing existing signature
Signing with identity "M4DQ8GQP99"
Signing /var/folders/dn/9c46q9997jq536qwbl3k67x40000gr/T/.tmpJn8d56/Sentinowl.zip
Notarizing /Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app
Notarizing Finished with status Accepted for id 8c4b306d-5a9f-443b-964d-7f51dcfd00d2 (Processing complete)
Stapling app...
    Bundling Sentinowl_0.10.1_aarch64.dmg (/Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/dmg/Sentinowl_0.10.1_aarch64.dmg)
     Running bundle_dmg.sh
     Signing with identity "M4DQ8GQP99"
Signing with identity "M4DQ8GQP99"
Signing /Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/dmg/Sentinowl_0.10.1_aarch64.dmg
    Bundling /Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app.tar.gz (/Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app.tar.gz)
    Finished 2 bundles at:
        /Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app
        /Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/dmg/Sentinowl_0.10.1_aarch64.dmg
        /Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app.tar.gz (updater)

    Finished 1 updater signature at:
        /Users/sentinowl/src/sentinowl-desktop/core/target/aarch64-apple-darwin/release/bundle/macos/Sentinowl.app.tar.gz.sig

macos host + cargo-xwin:

   Compiling sentinowl v0.10.1 (/Users/sentinowl/src/sentinowl-desktop/core)
    Finished `release` profile [optimized] target(s) in 31.70s
       Built application at: /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe
        Warn Cross-platform compilation is experimental and does not support all features. Please use a matching host system for full compatibility.
        Warn Signing, by default, is only supported on Windows hosts, but you can specify a custom signing command in `bundler > windows > sign_command`, for now, skipping signing the installer...
        Info Patching /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe with bundle type information: nsis
        Info Target: x64
     Running makensis to produce /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe
warning 5202: -OUTPUTCHARSET is disabled for non Win32 platforms.
        Warn Signing, by default, is only supported on Windows hosts, but you can specify a custom signing command in `bundler > windows > sign_command`, for now, skipping signing the installer...
    Finished 1 bundle at:
        /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe

    Finished 1 updater signature at:
        /Users/sentinowl/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe.sig

linux host + cargo-xin:

   Compiling sentinowl v0.10.1 (/src/sentinowl-desktop/core)
    Finished `release` profile [optimized] target(s) in 25.15s
       Built application at: /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe
        Warn Cross-platform compilation is experimental and does not support all features. Please use a matching host system for full compatibility.
     Signing ../../build-artifacts/smartmontools/smartctl-x86_64-pc-windows-msvc.exe
     Signing ../../build-artifacts/smartmontools/smartctl-x86_64-pc-windows-msvc.exe with a custom signing command
     Signing Output of signing command:
skipping signing of smartctl binary [../../build-artifacts/smartmontools/smartctl-x86_64-pc-windows-msvc.exe]
        Info Patching /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe with bundle type information: nsis
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe with a custom signing command
     Signing Output of signing command:
Adding Authenticode signature to /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/sentinowl.exe
        Info Target: x64
        Info Signing NSIS plugins
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/NSISdl.dll
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/NSISdl.dll with a custom signing command
     Signing Output of signing command:
skipping signing of dll [/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/NSISdl.dll]
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/StartMenu.dll
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/StartMenu.dll with a custom signing command
     Signing Output of signing command:
skipping signing of dll [/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/StartMenu.dll]
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/System.dll
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/System.dll with a custom signing command
     Signing Output of signing command:
skipping signing of dll [/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/System.dll]
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/nsDialogs.dll
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/nsDialogs.dll with a custom signing command
     Signing Output of signing command:
skipping signing of dll [/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/nsDialogs.dll]
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/additional/nsis_tauri_utils.dll
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/additional/nsis_tauri_utils.dll with a custom signing command
     Signing Output of signing command:
skipping signing of dll [/src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/nsis/x64/Plugins/x86-unicode/additional/nsis_tauri_utils.dll]
     Running makensis to produce /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe
warning 5202: -OUTPUTCHARSET is disabled for non Win32 platforms.
Adding Authenticode signature to /tmp/makensisgFoE6r
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe
     Signing /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe with a custom signing command
     Signing Output of signing command:
Adding Authenticode signature to /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe
    Finished 1 bundle at:
        /src/sentinowl-desktop/core/target/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe

    Finished 1 updater signature at:
        /home/sam/var/cargo-build/sentinowl/x86_64-pc-windows-msvc/release/bundle/nsis/Sentinowl_0.10.1_x64-setup.exe.sig

@acx0 acx0 requested a review from FabianLars March 17, 2026 16:03
Comment on lines +52 to +53
// skip patching for macOS-native bundles
return Ok(())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm okay with this but i think we should keep the _ => Error and only return Ok(()) for the MacOsBundle and Dmg PackageTypes. what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Co-authored-by: Fabian-Lars <30730186+FabianLars@users.noreply.github.com>
FabianLars
FabianLars previously approved these changes Mar 17, 2026
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for putting up with me :D

@FabianLars FabianLars merged commit fcb702e into tauri-apps:dev Mar 17, 2026
13 checks passed
@github-project-automation github-project-automation bot moved this from 📬Proposal to 🔎 In audit in Roadmap Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants