Feature #158773 chore: Rating Field in TjUcm#363
Open
shraddhaSankpal27 wants to merge 5 commits intotechjoomla:release-1.2.4from
Open
Feature #158773 chore: Rating Field in TjUcm#363shraddhaSankpal27 wants to merge 5 commits intotechjoomla:release-1.2.4from
shraddhaSankpal27 wants to merge 5 commits intotechjoomla:release-1.2.4from
Conversation
| } | ||
|
|
||
| /****** Style Star Rating Widget *****/ | ||
| fieldset, label { margin: 0; padding: 0; } |
Collaborator
There was a problem hiding this comment.
@shraddhaSankpal27 direct CSS for bootstrap classes are not recommended, use UCM wrapper class with the CSS class.
e.g .ucm-wrapper .label{
CSS
}
Again, this can cause issues in other fields label and ieldsets. We should not write CSS for generic classes of bootstrap. The input and label should use template CSS only
There was a problem hiding this comment.
@ankush-maherwal @shraddha : Update the generic css for rating and also rating star use
images that will good option.
shraddhaSankpal27
changed the title
shraddhaSankpal27
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.