Created a style file for each component#270
Created a style file for each component#270EnechukwuChibuike wants to merge 2 commits intotechnojam:masterfrom
Conversation
|
Thankyou @EnechukwuChibuike |
|
@EnechukwuChibuike can you please make this PR in our another branch name separateCSS |
| backgroundPositionX: 'center', | ||
|
|
||
| width: "100%", | ||
|
|
There was a problem hiding this comment.
what you have changed here
| text: { | ||
| appearance: 'none', | ||
| width: '100%', | ||
| appearance: "none", |
There was a problem hiding this comment.
these things should be in the separate CSS file of contacts components
| className="card--shadow" | ||
| style={{ borderRadius: "10px" }} | ||
| > | ||
| <div style={{ backgroundColor: '#24292E' }}> |
There was a problem hiding this comment.
we don't want double-quotes. Move this CSS in separate file
There was a problem hiding this comment.
we don't want double-quotes. Move this CSS in separate file
Calm down
You know you used material-ui framework
Not all styles can be moved to a different file
| <Card style={{ borderRadius: '10px', fontSize: '14px' }} className="card--shadow"> | ||
| <Card | ||
| style={{ borderRadius: "10px", fontSize: "14px" }} | ||
| className="card--shadow" | ||
| > |
There was a problem hiding this comment.
nothing is changed in these lines
| appearance: 'none', | ||
| width: '100%', | ||
| padding: '5px', | ||
| height: '35px', | ||
| borderRadius: '5px', | ||
| outline: 'none', | ||
| border: 'none', | ||
| background: '#e8ebed', | ||
| color: '#576366', | ||
| fontSize: '14px' | ||
| }, | ||
| textDisabled: { | ||
| appearance: 'none', | ||
| width: '100%', | ||
| padding: '5px', | ||
| height: '35px', | ||
| borderRadius: '5px', | ||
| outline: 'none', | ||
| border: 'none', | ||
| background: 'rgb(212, 213, 214)', | ||
| color: '#576366', | ||
| fontSize: '14px' | ||
| }, | ||
| label: { | ||
| color: '#e83b7c' | ||
| } |
There was a problem hiding this comment.
same as previous code
Ok |
|
You didn't accept my pull request |
|
@ravisaxena23 Accept my pull request |
2 participants
Created componentName.styles for all the components
Separated the useStyles from the components