Skip to content

feat: Add toolbar feedback buttons with Sentry feedback form integration - #33

Merged
philprime merged 5 commits into
mainfrom
feature/feedback-button
Jun 24, 2026
Merged

feat: Add toolbar feedback buttons with Sentry feedback form integration#33
philprime merged 5 commits into
mainfrom
feature/feedback-button

Conversation

@philprime

@philprime philprime commented Sep 18, 2025

Copy link
Copy Markdown
Member

Summary

  • Add a feedback megaphone toolbar button to all 6 main screens (lists, list detail, link detail, link info, create list, create link)
  • Introduce FeedbackAction environment value so views call feedback.show() without importing SentrySwift directly
  • Adopt the new SentryFeedbackFormConfig API from sentry-cocoa for manual feedback form presentation
  • Remove the floating feedback widget (showWidget()) in favor of explicit toolbar buttons
  • Remove dead widget configuration from configureUserFeedback
  • Add localization strings for the feedback button (label, accessibility label/hint)

Test plan

  • UI tests for all 6 feedback buttons pass (make test-ui-ios-app, 7/7 green)
  • Each test navigates to the screen, taps the feedback button, and verifies the Sentry feedback form opens
  • Tests run with TESTING=1 (Sentry disabled, in-memory DB) so no real feedback is sent
  • make build succeeds

@philprime
philprime force-pushed the feature/feedback-button branch 2 times, most recently from 00ae2ba to a81e603 Compare June 2, 2026 11:40
@philprime philprime changed the title feat: Add toolbar button to display user feedback UI feat: Add toolbar feedback buttons with Sentry feedback form integration Jun 2, 2026
@sentry

sentry Bot commented Jun 2, 2026

Copy link
Copy Markdown

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
Flinky com.techprimate.Flinky 1.1.5 (3) --

⚙️ flinky Build Distribution Settings

@philprime
philprime marked this pull request as ready for review June 23, 2026 13:23
@philprime
philprime enabled auto-merge (squash) June 23, 2026 13:23
Comment thread Targets/App/Sources/UI/LinkDetail/LinkDetailRenderView.swift Outdated
@philprime
philprime force-pushed the feature/feedback-button branch from 6e9678f to 15a0130 Compare June 24, 2026 07:08
@philprime
philprime merged commit 6149e50 into main Jun 24, 2026
7 checks passed
@philprime
philprime deleted the feature/feedback-button branch June 24, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant