Skip to content

[codex] Add remaining 2.1.0 issue fixes#1

Merged
teddychan merged 8 commits into
mainfrom
codex/ice-2-open-issues-2-1-0
Jun 25, 2026
Merged

[codex] Add remaining 2.1.0 issue fixes#1
teddychan merged 8 commits into
mainfrom
codex/ice-2-open-issues-2-1-0

Conversation

@teddychan

Copy link
Copy Markdown
Owner

Summary

Validation

  • git diff --check
  • git diff --cached --check
  • Build intentionally not run per request.

Release

  • Tagged this commit as 2.1.0 and pushed the tag to origin.

@teddychan

Copy link
Copy Markdown
Owner Author

Reviewed this PR (high-effort, multi-angle). Not merging as-is — verification found one confirmed functional bug plus several plausible regressions:

  • Confirmed: Ice's own spacer items get captured into layout profiles / item groups and then moved/clicked on profile-apply or trigger (only isControlItem was excluded, not isSpacerItem).
  • Plausible: overlay panel frame built from CoreGraphics window bounds (Y-down) passed to NSPanel.setFrame (AppKit, Y-up) with no conversion → mis-positioned on non-primary displays; temporarily-shown items matched only by windowID (unstable across window recreation) → can be stranded; duplicate default profile/group names after deletions.

Rather than merge here, I opened #2 which contains this branch's work plus the corrections (and a couple of quality cleanups). See that PR for the full list, including items I reviewed and intentionally left unchanged. Suggest closing this in favor of #2 once #2 builds green in CI.

Note: build was not run in either case — please CI-build #2 before release.

teddychan added a commit that referenced this pull request Jun 25, 2026
Fix review issues in 2.1.0 menu bar work (supersedes #1)
@teddychan
teddychan merged commit 0ef4949 into main Jun 25, 2026
1 check passed
@teddychan

Copy link
Copy Markdown
Owner Author

Note: GitHub auto-marked this as merged because #2 (built on top of this branch) landed on main#2 contains all of this branch's commits plus the review-fix corrections. The corrected work is what shipped; no action needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant