[codex] Add remaining 2.1.0 issue fixes#1
Merged
Conversation
…es-2-1-0 # Conflicts: # Ice.xcodeproj/project.pbxproj # Ice/Settings/SettingsPanes/HotkeysSettingsPane.swift
Owner
Author
|
Reviewed this PR (high-effort, multi-angle). Not merging as-is — verification found one confirmed functional bug plus several plausible regressions:
Rather than merge here, I opened #2 which contains this branch's work plus the corrections (and a couple of quality cleanups). See that PR for the full list, including items I reviewed and intentionally left unchanged. Suggest closing this in favor of #2 once #2 builds green in CI. Note: build was not run in either case — please CI-build #2 before release. |
teddychan
added a commit
that referenced
this pull request
Jun 25, 2026
Fix review issues in 2.1.0 menu bar work (supersedes #1)
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checkgit diff --cached --checkRelease
2.1.0and pushed the tag toorigin.