Skip to content

feat(tracing): add spans for task parameter and workspace substitution #9801#10271

Open
Cordagr wants to merge 2 commits into
tektoncd:mainfrom
Cordagr:feat/add-spanning-for-task-parameters-and-workspace-substitution
Open

feat(tracing): add spans for task parameter and workspace substitution #9801#10271
Cordagr wants to merge 2 commits into
tektoncd:mainfrom
Cordagr:feat/add-spanning-for-task-parameters-and-workspace-substitution

Conversation

@Cordagr

@Cordagr Cordagr commented Jun 13, 2026

Copy link
Copy Markdown

Changes

Add tracing spans to the task parameter and workspace substitution pipeline in the TaskRun reconciler. The orchestrating function applyParamsContextsResultsAndWorkspaces is called on every reconcile but has zero tracing.

Submitter Checklist

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add tracing spans to the task parameter and workspace substitution pipeline in the TaskRun reconciler to improve observability and performance tracking. No user-facing changes.

/kind feature
Fixes #9801

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 13, 2026
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 13, 2026
@Cordagr

Cordagr commented Jun 13, 2026

Copy link
Copy Markdown
Author

Applied the feedback from @waveywaves that was provided on the previous PR. This PR was recreated after cleaning up the branch history.

waveywaves
waveywaves reviewed Jun 15, 2026
View reviewed changes

@waveywaves waveywaves left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some simplification comments on the tracing shape.

Comment thread pkg/reconciler/taskrun/resources/apply.go Outdated
Comment thread pkg/reconciler/taskrun/taskrun.go Outdated
Comment thread pkg/reconciler/taskrun/taskrun.go Outdated
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2026
@Cordagr Cordagr requested a review from waveywaves June 15, 2026 18:03
@waveywaves

waveywaves commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@Cordagr you gotta squash all your commits to one, then I believe we would be good to go

@tekton-robot

tekton-robot commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2026
@Cordagr Cordagr force-pushed the feat/add-spanning-for-task-parameters-and-workspace-substitution branch from b47cb9f to 3676fdf Compare June 17, 2026 21:33
@Cordagr

Cordagr commented Jun 17, 2026

Copy link
Copy Markdown
Author

@waveywaves I've squashed my commits thank you!

@waveywaves

waveywaves commented Jun 17, 2026

Copy link
Copy Markdown
Member

@Cordagr lint is failing

@Cordagr Cordagr force-pushed the feat/add-spanning-for-task-parameters-and-workspace-substitution branch from cefd7e7 to 30e0c4e Compare June 17, 2026 23:50
@Cordagr Cordagr force-pushed the feat/add-spanning-for-task-parameters-and-workspace-substitution branch from 30e0c4e to 352d9f6 Compare June 17, 2026 23:50
@Cordagr

Cordagr commented Jun 17, 2026

Copy link
Copy Markdown
Author

@waveywaves It should be fixed now sorry for the inconvenience

@waveywaves

waveywaves commented Jun 18, 2026

Copy link
Copy Markdown
Member

@Cordagr it's all good don't worry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waveywaves waveywaves waveywaves approved these changes

@abayer abayer Awaiting requested review from abayer

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(tracing): add spans for task parameter and workspace substitution

3 participants

@Cordagr @waveywaves @tekton-robot