feat(github): add blob caching with RWMutex#2601
Draft
theakshaypant wants to merge 2 commits intotektoncd:mainfrom
Draft
feat(github): add blob caching with RWMutex#2601theakshaypant wants to merge 2 commits intotektoncd:mainfrom
theakshaypant wants to merge 2 commits intotektoncd:mainfrom
Conversation
Implement in-memory blob caching for GitHub provider to reduce duplicate API calls. Cache is thread-safe using RWMutex to allow concurrent reads while ensuring exclusive writes. Fix tests to use New() factory pattern for proper cache init Fix ambiguous mutex selector in canIUseCheckrunID() Fixes tektoncd#2376 Signed-off-by: Akshay Pant <akpant@redhat.com>
E2E instrumentation was broken because it searched for the
controller in the test namespace (e.g., pac-e2e-ns-*), but
controllers actually run in installation namespaces
(pipelines-as-code or openshift-pipelines).
The fix iterates through info.InstallNamespaces to find the
controller, restoring the original behavior that searched across
all namespaces. Also fixed linter warning (interface{} to any).
Signed-off-by: Akshay Pant <akpant@redhat.com>
Assisted-by: Claude <noreply@anthropic.com>
Member
|
I think this is going to increase memory more than decrease? |
Member
Author
This is unrelated to the memory issue but focused on the API optimizations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description of the Change
Implement in-memory blob caching for GitHub provider to reduce duplicate API calls. Cache is thread-safe using RWMutex to allow concurrent reads while ensuring exclusive writes.
Fix tests to use New() factory pattern for proper cache init
Fix ambiguous mutex selector in canIUseCheckrunID()
🔗 Linked GitHub Issue
Fixes #2376
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.