Add angular feedforward to the flywheel calculator#2065
Draft
Eeshwar-Krishnan wants to merge 1 commit intotervay:mainfrom
Draft
Add angular feedforward to the flywheel calculator#2065Eeshwar-Krishnan wants to merge 1 commit intotervay:mainfrom
Eeshwar-Krishnan wants to merge 1 commit intotervay:mainfrom
Conversation
Eeshwar-Krishnan
temporarily deployed
to
recalc-env
GitHub Actions
Inactive
Eeshwar-Krishnan
temporarily deployed
to
recalc-env
GitHub Actions
Inactive
Owner
|
Deploy preview for recalc ready! ✅ Preview Built with commit efd06cf. |
tervay
requested changes
Feb 24, 2026
Owner
tervay
left a comment
tervay
left a comment
There was a problem hiding this comment.
couple minor things, otherwise lgtm
| kA: Measurement; | ||
| distanceType: "linear" | "angular"; | ||
| kG?: Measurement; | ||
| kVAlt?: Measurement; |
Owner
There was a problem hiding this comment.
I would just name these kvAngular and kaAngular rather than 'alt'
|
|
||
| // kA = V_nominal * I / tau_stall | ||
| // Units: V * kg*m^2 / (N*m) = V * s^2 | ||
| const kAInSec = nominalVoltage.mul(moiInSI).div(stallTorqueAtShooter); |
Owner
There was a problem hiding this comment.
Add a division by zero guard above this
if stallTorqueAtShooter == 0
return new Measurement(0, "...")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference implementation/closing #2064
Minimal change, added a seperate kV (angular) and kA (angular). I considered adding them to the dropdown, but this would require additional changes to Measurements which is probably overscoped for a minimal change to the flywheel system.