Skip to content

useFavicon hook in Record Avatar component. #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
torkinos merged 5 commits into from
Feb 27, 2026
Merged

useFavicon hook in Record Avatar component. #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6320d8
useFavicon hook in Record Avatar component.
harrisaar-noxtton Feb 15, 2026
1428f46
Merge branch 'dev' into useFavicon-mobile-support
harrisaar-noxtton Feb 18, 2026
769683a
update submodule pointers for vault and core
harrisaar-noxtton Feb 18, 2026
b901093
Update GitHub Actions workflows to use 'npm install' instead of 'npm …
torkinos Feb 18, 2026
01e836b
Merge branch 'dev' into useFavicon-mobile-support
harrisaar-noxtton Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
node-version: "22.x"

- name: Install dependencies
run: npm ci
run: npm install

- name: Run ESLint
run: npm run lint
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
node-version: "22.x"

- name: Install dependencies
run: npm ci
run: npm install

- name: Compile locale files
run: npm run lingui:compile
Expand Down
2 changes: 1 addition & 1 deletion packages/pearpass-lib-vault
Open in desktop
Submodule pearpass-lib-vault updated 5 files
+1 −1 README.md
+59 −0 src/hooks/useFavicon.js
+123 −0 src/hooks/useFavicon.test.js
+23 −3 src/hooks/useVault.js
+1 −0 src/index.js
2 changes: 1 addition & 1 deletion packages/pearpass-lib-vault-core
Open in desktop
Submodule pearpass-lib-vault-core updated 9 files
+1 −0 package.json
+12 −0 src/pearpassVaultClient/index.js
+11 −0 src/utils/urlUtils.js
+45 −0 src/utils/urlUtils.test.js
+2 −1 src/worklet/api.js
+32 −0 src/worklet/appCore.js
+78 −1 src/worklet/appCore.test.js
+106 −0 src/worklet/faviconManager.js
+134 −0 src/worklet/faviconManager.test.js
27 changes: 4 additions & 23 deletions src/components/AvatarRecord/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import { Buffer } from 'buffer'

import { useMemo } from 'react'

import { generateAvatarInitials } from 'pear-apps-utils-avatar-initials'
import { CheckIcon, StarIcon } from 'pearpass-lib-ui-react-native-components'
import { colors } from 'pearpass-lib-ui-theme-provider/native'
import { getDefaultFavicon } from 'pearpass-lib-vault'
import { useFavicon } from 'pearpass-lib-vault'

import {
AvatarImage,
Expand All @@ -14,7 +12,6 @@ import {
ItemImageContainer
} from './styles'
import { RECORD_COLOR_BY_TYPE } from '../../constants/recordColorByType'
import { extractDomainName } from '../../utils/extractDomainName'

global.Buffer = global.Buffer || Buffer

Expand All @@ -34,23 +31,7 @@ export const AvatarRecord = ({
isSelected,
websiteDomain
}) => {
const avatarSrc = useMemo(() => {
if (!websiteDomain) {
return null
}

const website = extractDomainName(websiteDomain)

const avatarBuffer = getDefaultFavicon(website) || null

if (!avatarBuffer) {
return null
}

const base64 = Buffer.from(avatarBuffer).toString('base64')

return base64 ? `data:image/png;base64,${base64}` : null
}, [websiteDomain])
const { faviconSrc } = useFavicon({ url: websiteDomain })

if (isSelected) {
return (
Expand All @@ -62,10 +43,10 @@ export const AvatarRecord = ({

return (
<ItemImageContainer isSelected={isSelected} size={size}>
{avatarSrc ? (
{faviconSrc ? (
<AvatarImage
testID="avatar-image"
source={{ uri: avatarSrc }}
source={{ uri: faviconSrc }}
size={size}
/>
) : (
Expand Down
16 changes: 15 additions & 1 deletion src/components/AvatarRecord/index.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,21 @@ jest.mock('pearpass-lib-ui-react-native-components', () => ({
}))

jest.mock('pearpass-lib-vault', () => ({
getDefaultFavicon: jest.fn()
getDefaultFavicon: jest.fn(),
useFavicon: jest.fn(({ url }) => {
const { getDefaultFavicon } = require('pearpass-lib-vault')
const { extractDomainName } = require('../../utils/extractDomainName')

if (!url) return { faviconSrc: null }

const domain = extractDomainName(url)
const buffer = getDefaultFavicon(domain)

if (!buffer) return { faviconSrc: null }

const base64 = buffer.toString('base64')
return { faviconSrc: `data:image/png;base64,${base64}` }
})
}))

jest.mock('../../utils/extractDomainName', () => ({
Expand Down