infra[notask]: add qvac-ci pending-approval workflow and update CODEOWNERS#48
Open
sidj-thr wants to merge 3 commits into
Open
infra[notask]: add qvac-ci pending-approval workflow and update CODEOWNERS#48sidj-thr wants to merge 3 commits into
sidj-thr wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
ai-runtime-merge-mgmtin both CODEOWNERS and the--maintainers-teamflag. The management team has been renamed toqvac-internal-mgmtper the GitHub org restructuring (github-opsPR #182).Count Pending Approvals/count-reviews) did not match theCheck Approvals/check-approvalsnaming convention required for branch protection status checks.📝 How does it solve it?
.github/CODEOWNERS: replaces@tetherto/ai-runtime-merge-mgmtwith@tetherto/qvac-internal-mgmt..github/workflows/check-pending-approval.yml: renames workflow name, job id (count-reviews→check-approvals), job display name, and step name toCheck Approvals; updates--maintainers-teamflag toqvac-internal-mgmt.🧪 How was it tested?
Validated on
tetherto/qvac-internalagainst a 3-case matrix before rollout:qvac-internal-mergeapproved → workflow passed, PR mergeable. ✅qvac-internal-merge+ 1qvac-internal-devapproved → workflow passed, PR mergeable (code-owner approval satisfied). ✅qvac-internal-devmembers approved → workflow reported pending, PR blocked by CODEOWNERS ruleset (no code-owner approval). ✅ (expected failure)🛡️ Permissions changes
contents: read,pull-requests: write,issues: write(set in the initial commit on this branch)contents: read,pull-requests: write,issues: write