Skip to content

UI: update React to 18#8915

Open
pedro-stanaka wants to merge 4 commits into
thanos-io:mainfrom
pedro-stanaka:fix/react18-graph-test
Open

UI: update React to 18#8915
pedro-stanaka wants to merge 4 commits into
thanos-io:mainfrom
pedro-stanaka:fix/react18-graph-test

Conversation

@pedro-stanaka

@pedro-stanaka pedro-stanaka commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

This updates the React UI from React 16 to React 18 as part of my plan to improve the UI.

The UI stack and routing are not changed and the existing Enzyme tests use a React 18-compatible adapter.

Changes

  • Update React, React DOM, React test renderer, and their TypeScript definitions to React 18.
  • Replace the React 16 Enzyme adapter with the React 18-compatible adapter.
  • Migrate the application entrypoint from ReactDOM.render to createRoot.
  • Add the small React 18 type compatibility fixes required by the existing components and test setup.
  • Make the graph hover test deterministic around its requestAnimationFrame callback.

Assisted-By: devx/8a3b3ae0-6e4a-42fb-bd88-de1629d17909
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Assisted-By: devx/8a3b3ae0-6e4a-42fb-bd88-de1629d17909
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
pedro-stanaka force-pushed the fix/react18-graph-test branch from d435c89 to e9fa6a2 Compare July 14, 2026 11:20
Assisted-By: devx/8a3b3ae0-6e4a-42fb-bd88-de1629d17909
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
pedro-stanaka force-pushed the fix/react18-graph-test branch from e9fa6a2 to fddd3f8 Compare July 14, 2026 11:20
@pedro-stanaka
pedro-stanaka marked this pull request as ready for review July 14, 2026 11:21
Assisted-By: devx/8a3b3ae0-6e4a-42fb-bd88-de1629d17909
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
pedro-stanaka force-pushed the fix/react18-graph-test branch from 4e60376 to 73f4b6f Compare July 14, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant