This repository was archived by the owner on Feb 19, 2021. It is now read-only.
Upgrade to Django 2.2 LTS#702
Open
jayme-github wants to merge 4 commits intothe-paperless-project:masterfrom
Open
Upgrade to Django 2.2 LTS#702jayme-github wants to merge 4 commits intothe-paperless-project:masterfrom
jayme-github wants to merge 4 commits intothe-paperless-project:masterfrom
Conversation
...and don't read the whole file if there is no need to
The app.add_stylesheet() is deprecated. Please use app.add_css_file() instead.
Sblop
approved these changes
Nov 23, 2020
Sblop
approved these changes
Nov 23, 2020
Sblop
approved these changes
Nov 23, 2020
Sblop
approved these changes
Nov 23, 2020
MasterofJOKers
approved these changes
Jan 5, 2021
Contributor
MasterofJOKers
left a comment
MasterofJOKers
left a comment
There was a problem hiding this comment.
and don't read the whole file if there is no need to
Should have been its own commit instead of hiding it in the second line of a commit message.
Comment on lines
+57
to
+61
| count = 0 | ||
| for line in src: | ||
| if count >= n_lines: | ||
| break | ||
| count += 1 |
Contributor
There was a problem hiding this comment.
Imho better with enumerate
for count, line in enumerate(src, start=1):
if count >= n_lines:
break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update paperless to the latest Django 2.2 (LTS) release. Django 2.0 is already EOL since April 2019.
I also dropped python 3.5 from the matrix (EOL September 2020) as it requires zipp 1.x and therefore extra rules in Pipenv to generate a working requirements.txt. If that's a problem let me know and I'll look into that.
Supersedes / Closes #671