refactor: use a refinement type for Data.Vec#586
Open
4e554c4c wants to merge 1 commit into
Open
Conversation
Member
Changed pages
|
plt-amy
reviewed
Jan 27, 2026
plt-amy
reviewed
Jan 27, 2026
plt-amy
reviewed
Jan 27, 2026
plt-amy
reviewed
Jan 27, 2026
plt-amy
reviewed
Feb 25, 2026
plt-amy
reviewed
Feb 25, 2026
595e093 to
bc884da
Compare
Contributor
Author
|
this is now rebased on #597 and doesn't chmod borceaux |
Contributor
Author
|
rebase'd |
plt-amy
reviewed
Mar 16, 2026
plt-amy
reviewed
Mar 16, 2026
9fcc2c2 to
7e8dc73
Compare
plt-amy
requested changes
Jun 26, 2026
plt-amy
requested changes
Jun 26, 2026
f7b1828 to
dfd33fd
Compare
plt-amy
requested changes
Jun 30, 2026
plt-amy
left a comment
Member
There was a problem hiding this comment.
i'm reading this on the github web editor so the line length limit comments are eyeballed
c7b498e to
fc1d729
Compare
plt-amy
reviewed
Jun 30, 2026
resolves: the1lab#567 Co-authored-by: Reed Mullanix <reedmullanix@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: #567
Description
As per a suggestion by @TOTBWF, this changes
Data.Vecto use a refinement type which codeslength xs = n.Unfortunately this means that induction on vecs now needs
vec-view, which makes some things messier. Worse still, I can't seem to use[]as a pattern for the empty vec since it conflicts with list, and use∷at all since it can't be a pattern.The order of instances is also changed a little bit, which means
[ p ]fails to realize as a list in1Lab.Reflection.List.I'd love some tips on how to make this a little bit cleaner :)
Checklist
Before submitting a merge request, please check the items below:
support/sort-imports.hs(ornix run --experimental-features nix-command -f . sort-imports).