Adjust transmart-batch to load high-dim data in the new way#122
Adjust transmart-batch to load high-dim data in the new way#122ewelinajozwik wants to merge 5 commits intodevfrom
Conversation
Fix NOS-4 - loading of gene expression data Make tm-batch load high-dim data with the new observations/modifiers that this data needs in 17.1: - High dim observations having textual value with sample name (subject sample mapping). - Modifier on it specifying high dim data type and as value assay ID.
| sourcesystem_cd: STUDY_ID | ||
| assert count == 45 | ||
| } | ||
|
|
There was a problem hiding this comment.
it would be nice to add a test for the column values of the HD observation rows.
...art-batch/src/main/groovy/org/transmartproject/batch/facts/ObservationFactStepsConfig.groovy
Show resolved
Hide resolved
| // add modifier for each assay_id | ||
| String modifier = 'TRANSMART:HIGHDIM:' + platform.markerType.toUpperCase() | ||
| for (int i=0; i<result.size(); i++){ | ||
| rowSet.instanceNum = i+1 |
There was a problem hiding this comment.
it does not look right. instance_id should be unique for each row. Pass it maybe to addValue method?
| """, [study_num: study.studyNum] | ||
|
|
||
| if (trialVisit) { | ||
| def t = trialVisit?.first() |
There was a problem hiding this comment.
Would it work for the data people to bind row with a first trial visit from the study? If so you should do it once per job.
There was a problem hiding this comment.
I wasn't sure how to get a trial visit there and what to do, if there is more than one visit or none (for now there is a function to add a default visit then)
transmart-batch/src/main/groovy/org/transmartproject/batch/facts/DummyFactGenerator.groovy
Outdated
Show resolved
Hide resolved
| protected void doClose() throws Exception {} | ||
|
|
||
| private List<Map<String, Object>> getAssayIds(String sample_id) { | ||
| List result = jdbcTemplate.queryForList """ |
There was a problem hiding this comment.
What about making the result of the query the main data source, instead of reading from subjectConceptMappingFileRows?
Added conditional before destroying analysis dialog
Added conditional before destroying analysis dialog
ewelinajozwik
force-pushed
the
dev
branch
3 times, most recently
from
93183e7 to
b651751
Compare
2 participants
Fix NOS-4 - loading of gene expression data
Make tm-batch load high-dim data with the new observations/modifiers in 17.1:
sample mapping).