Fix the failing dependency installiation for website buidling #18
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix failing dependency installation for the website/documentation building workflow by updating the GitHub Actions workflow configuration.
Key Changes:
- Replaced CUDA toolkit installation with a more streamlined approach, removing unnecessary CUDA dependencies
- Updated dependency installation to use
pip-compilefor generating a locked requirements file frompyproject.toml - Switched from
siacodelabs/setup-pandocto the officialpandoc/actions/setupaction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/website.yaml
Outdated
| (github.event_name == 'push' && github.ref == 'refs/heads/main') || | ||
| (github.event.pull_request.merged == true && | ||
| github.event.pull_request.base.ref == 'main') |
There was a problem hiding this comment.
The condition github.event.pull_request.merged == true will not work as intended. When a pull request is merged, the triggered event is a push event to the main branch, not a pull_request event. The github.event.pull_request context will be null/undefined in push events. Since line 63 already handles the push to main case, lines 64-65 are unnecessary and will never evaluate to true. Consider removing these lines or clarifying the intended behavior.
| (github.event_name == 'push' && github.ref == 'refs/heads/main') || | |
| (github.event.pull_request.merged == true && | |
| github.event.pull_request.base.ref == 'main') | |
| github.event_name == 'push' && github.ref == 'refs/heads/main' |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This PR fixes the problem of requiring the installation of the whole package to build the Sphinx website.