Fix test and doc errors and warnings with most recent dependencies - #407
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated Sphinx autodoc skip logic in docs/conf.py has a concrete correctness gap for imported members that lack __module__, so it may not actually suppress external/imported symbols as intended.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR performs maintenance updates to keep the project compatible with newer tooling and dependencies: updating build-system requirements, modernizing Sphinx version retrieval, reducing doc build warnings, and updating tests/CI ergonomics.
Changes:
- Bump build-system dependencies and expand supported Python classifiers; update pytest-xdist settings for better parallel scheduling.
- Modernize/adjust unit tests to avoid deprecated pytest patterns and warnings.
- Refresh documentation and pre-commit tooling configuration.
File summaries
| File | Description |
|---|---|
| pyproject.toml | Updates build-system requirements, adds Python 3.14 classifier, and tweaks pytest addopts for xdist worksteal. |
| iodata/test/test_overlap.py | Adjusts parametrization input to avoid pytest warnings with iterables. |
| iodata/test/test_iodata.py | Replaces deprecated pytest.raises call style with context-manager usage. |
| docs/requirements.txt | Removes setuptools_scm from doc requirements (no longer needed for version resolution). |
| docs/conf.py | Switches doc version discovery to importlib.metadata.version and adjusts autodoc skip logic. |
| .pre-commit-config.yaml | Updates hook revisions to newer releases. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@FanwangM I'm not sure how available you are for review? Feel free to decline and note that this is not urgent, just cleaning. (I can also ping someone else.) Thanks. |
|
Thanks for checking |
|
Sorry I haven't been able to check this repo more often. @tovrstra |
This is just maintenance: