Drop MacOS 13 testing #223
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies the CI testing matrix by removing the explicit MacOS 13 runner and consolidating to the latest MacOS version. The change reduces redundant testing while maintaining coverage across the three major operating systems (MacOS, Windows, and Ubuntu) with Python versions 3.9 through 3.13.
Key Changes
- Removed
macos-13from the test matrix, keeping onlymacOS-latest - Cleaned up a commented-out line showing the previous matrix configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/ci_tox.yml
Outdated
| # Scheduled workflows run on the latest commit on the default or base branch. | ||
| # (from https://help.github.com/en/actions/reference/events-that-trigger-workflows#scheduled-events-schedule) | ||
| - cron: "0 0 * * *" | ||
| # 4:30 UTC, every day of month, every month, 1st day of week (Monday) |
There was a problem hiding this comment.
The cron schedule comment states "1st day of week (Monday)" but the cron expression "30 4 * * 1" actually means the job runs every Monday, not just the first Monday. The current comment is misleading. If the intent is to run weekly on Mondays, the comment should say "every Monday" instead of "1st day of week (Monday)".
| # 4:30 UTC, every day of month, every month, 1st day of week (Monday) | |
| # 4:30 UTC, every Monday (day-of-week = 1), every month |
| matrix: | ||
| # os: [macOS-latest, windows-latest, ubuntu-latest] | ||
| os: [macos-13, macos-latest, windows-latest, ubuntu-latest] | ||
| os: [macOS-latest, windows-latest, ubuntu-latest] |
There was a problem hiding this comment.
Inconsistent capitalization in the OS names. The matrix now uses "macOS-latest" (with lowercase 'ac') while previously it was "macos-13" and "macos-latest" (all lowercase). For consistency with the removed values and GitHub Actions convention, consider using "macos-latest" instead of "macOS-latest".
| os: [macOS-latest, windows-latest, ubuntu-latest] | |
| os: [macos-latest, windows-latest, ubuntu-latest] |
No description provided.