-
Notifications
You must be signed in to change notification settings - Fork 200
WCA Live Nextjs Data Entry #12835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FinnIckler
wants to merge
26
commits into
thewca:main
Choose a base branch
from
FinnIckler:live-next-round-input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WCA Live Nextjs Data Entry #12835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype frontend:

I spend a bunch of time working on the
quit_from_roundmethod seeing if it is possible to not introduce a new table for it for quit competitors.It is definitely possible by handling it like WCA Live does (marking advancing as false in the previous round), but that does lock us into marking rounds as done again.
It's also pretty error prone, at least when you do it in the console manually and you can screw up your whole recomputation functions by having more
live_resultsthan registrations.Working on this prompted me to move the recomputation methods to the round model as they need to be called again when someone is quit from the round. I do think that is a better place for them anyway as it recomputes everything per round and not per
live_result