This repository was archived by the owner on Jun 7, 2026. It is now read-only.
fix #53: support Python 3.13+, replace eyre with anyhow - #108
Open
teng-lin wants to merge 3 commits into
Open
Conversation
Bump pyo3 0.20.3 -> 0.23 with abi3-py37 so rookiepy builds a single forward-compatible wheel that works on Python 3.7 through 3.14+. eyre 0.6's pyo3 feature is pinned to pyo3 ^0.20 with no newer release available, which blocked the bump. Swap eyre for anyhow throughout rookie-rs and enable pyo3's anyhow feature so anyhow::Error converts to PyErr automatically -- the bindings drop their manual map_err helper and use `?` directly. Verified: cp37-abi3 wheel imports and runs on Python 3.13.13 and 3.14.5. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
After the eyre→anyhow swap, rustfmt's import-ordering rules want
anyhow before alphabetically-later crates (base64, byteorder) and
the `use anyhow::bail; pub use anyhow::{self, Result};` block to
sit ahead of the other internal `use common::*` lines. Pure
formatting; no behavior change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pyo3 0.23 deprecates the implicit-default behavior for trailing Option<T> arguments (treats them as keyword-only with default None unless an explicit signature is given). The deprecation surfaces as clippy warnings, which the lint workflow escalates to errors via -D warnings. Annotate every pyfunction in bindings/python/src/browsers.rs with #[pyo3(signature = ...)] reflecting the existing call shape, so the binding API stays identical from Python's side while clippy goes green. No behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump pyo3 0.20.3 -> 0.23 with abi3-py37 so rookiepy builds a single forward-compatible wheel that works on Python 3.7 through 3.14+.
eyre 0.6's pyo3 feature is pinned to pyo3 ^0.20 with no newer release available, which blocked the bump. Swap eyre for anyhow throughout rookie-rs and enable pyo3's anyhow feature so anyhow::Error converts to PyErr automatically -- the bindings drop their manual map_err helper and use
?directly.Verified: cp37-abi3 wheel imports and runs on Python 3.13.13 and 3.14.5.