SiweExternal Auth - Login through static React EOA#123
Merged
0xFirekeeper merged 2 commits intomainfrom Jan 17, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 76.68% 76.71% +0.03%
==========================================
Files 28 28
Lines 4799 4802 +3
Branches 665 665
==========================================
+ Hits 3680 3684 +4
- Misses 945 946 +1
+ Partials 174 172 -2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows you to login to otherwise native-unavailable wallets such as Abstract Wallet & Coinbase Smart Wallet through a flow similar to OAuth, using SIWE.
Closes TOOL-3134
Related TOOL-3137
PR-Codex overview
This PR introduces support for a new authentication method called
SiweExternalin theInAppWalletsystem. It enhances the wallet's capabilities to integrate with external sign-in processes, improving user authentication options.Detailed summary
SiweExternaltoAuthProviderenumeration.SignInWithSiweRawAsyncmethod inEmbeddedWallet.PreAuth_SiweExternalandLoginWithSiweExternalmethods inEcosystemWallet.IThirdwebWalletinterface to expose properties and methods publicly.ToStringmethod inLoginPayloadDatafor JSON serialization.