Conversation
Closes TOOL-3145
joaquim-verges
approved these changes
Jan 23, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 76.64% 76.84% +0.20%
==========================================
Files 28 28
Lines 4804 4863 +59
Branches 665 666 +1
==========================================
+ Hits 3682 3737 +55
- Misses 948 953 +5
+ Partials 174 173 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes TOOL-3145
PR-Codex overview
This PR focuses on enhancing the
Thirdwebwallet functionality by introducing new properties, improving connection tracking, and updating wallet creation methods. It also incorporates theMoqpackage for testing purposes.Detailed summary
WalletIdproperty toInAppWallet,SmartWallet,PrivateKeyWallet, andEcosystemWallet.TrackConnectionandTrackTransactionmethods inUtils._wallettoWalletinThirdwebTransactionfor better accessibility.Moqpackage in project dependencies.