Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
- Coverage 72.69% 68.96% -3.73%
==========================================
Files 34 35 +1
Lines 5233 5520 +287
Branches 693 724 +31
==========================================
+ Hits 3804 3807 +3
- Misses 1254 1537 +283
- Partials 175 176 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the
ThirdwebContractclass by changing internal properties to public, adding new data structures for session keys and wrapped calls, and introducing methods for generating signatures and typed data definitions in theEngineWalletclass.Detailed summary
ThirdwebContractfrominternaltopublic.SessionKeyParams_7702,Call, andWrappedCallsclasses for handling session keys and wrapped calls.GenerateSignature_SmartAccount_7702_WrappedCallsandGenerateSignature_SmartAccount_7702methods inEIP712.cs.EngineWalletclass with methods for transaction handling and signing messages.