Skip to content

CompatHelper: bump compat for Optim in [weakdeps] to 2, (keep existing compat)#248

Open
github-actions[bot] wants to merge 1 commit intomainfrom
compathelper/new_version/2026-01-28-00-12-48-369-02357785839
Open

CompatHelper: bump compat for Optim in [weakdeps] to 2, (keep existing compat)#248
github-actions[bot] wants to merge 1 commit intomainfrom
compathelper/new_version/2026-01-28-00-12-48-369-02357785839

Conversation

@github-actions
Copy link

This pull request changes the compat entry for the Optim package from 1 to 1, 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@thorek1 thorek1 force-pushed the compathelper/new_version/2026-01-28-00-12-48-369-02357785839 branch from 889eb14 to 6530c4d Compare January 28, 2026 00:12
@github-actions
Copy link
Author

Benchmark Results

main 6530c4d... main / 6530c4d...
FS2000/NSSS 0.262 ± 0.0015 ms 14.2 ± 0.46 μs 18.4 ± 0.6
FS2000/covariance 0.364 ± 0.025 ms 0.104 ± 0.024 ms 3.49 ± 0.85
FS2000/irf 0.356 ± 0.015 ms 0.098 ± 0.016 ms 3.63 ± 0.63
FS2000/jacobian 0.814 ± 0.0054 μs 0.816 ± 0.0036 μs 0.997 ± 0.008
FS2000/lyapunov/bartels_stewart 0.0867 ± 0.01 ms 0.0852 ± 0.011 ms 1.02 ± 0.17
FS2000/lyapunov/bicgstab 19.3 ± 0.8 μs 19.4 ± 0.89 μs 0.996 ± 0.062
FS2000/lyapunov/doubling 20.8 ± 9 μs 20.6 ± 2.7 μs 1.01 ± 0.46
FS2000/lyapunov/gmres 20.7 ± 1.2 μs 21.2 ± 1.4 μs 0.979 ± 0.084
FS2000/qme/doubling 0.138 ± 0.0056 ms 0.142 ± 0.0072 ms 0.973 ± 0.063
FS2000/qme/schur 0.0715 ± 0.0086 ms 0.083 ± 0.0079 ms 0.861 ± 0.13
NAWM_EAUS_2008/NSSS 2.78 ± 0.057 ms 19.8 ± 1.2 ms 0.14 ± 0.0092
NAWM_EAUS_2008/covariance 22.6 ± 0.77 ms 0.0392 ± 0.0014 s 0.577 ± 0.029
NAWM_EAUS_2008/irf 11.4 ± 0.28 ms 28.3 ± 1.1 ms 0.403 ± 0.018
NAWM_EAUS_2008/jacobian 0.0759 ± 0.005 ms 0.0767 ± 0.0054 ms 0.989 ± 0.095
NAWM_EAUS_2008/lyapunov/bartels_stewart 22.7 ± 0.8 ms 22.7 ± 0.96 ms 1 ± 0.055
NAWM_EAUS_2008/lyapunov/bicgstab 0.229 ± 0.00081 s 0.185 ± 0.0011 s 1.24 ± 0.0086
NAWM_EAUS_2008/lyapunov/doubling 13.5 ± 0.99 ms 13.6 ± 0.93 ms 0.998 ± 0.1
NAWM_EAUS_2008/lyapunov/gmres 0.158 ± 0.0043 s 0.163 ± 0.0036 s 0.971 ± 0.034
NAWM_EAUS_2008/qme/doubling 30.4 ± 0.88 ms 30.7 ± 0.8 ms 0.99 ± 0.039
NAWM_EAUS_2008/qme/schur 17.1 ± 0.96 ms 17.2 ± 0.98 ms 0.995 ± 0.08
Smets_Wouters_2007/NSSS 0.186 ± 0.0085 ms 0.185 ± 0.0066 ms 1.01 ± 0.058
Smets_Wouters_2007/covariance 1.27 ± 0.055 ms 1.25 ± 0.056 ms 1.02 ± 0.064
Smets_Wouters_2007/irf 0.754 ± 0.056 ms 0.727 ± 0.061 ms 1.04 ± 0.12
Smets_Wouters_2007/jacobian 11.9 ± 17 μs 11.2 ± 17 μs 1.06 ± 2.2
Smets_Wouters_2007/lyapunov/bartels_stewart 1.21 ± 0.05 ms 1.18 ± 0.049 ms 1.02 ± 0.059
Smets_Wouters_2007/lyapunov/bicgstab 3.58 ± 0.066 ms 3.57 ± 0.069 ms 1 ± 0.027
Smets_Wouters_2007/lyapunov/doubling 0.521 ± 0.015 ms 0.519 ± 0.023 ms 1 ± 0.053
Smets_Wouters_2007/lyapunov/gmres 6.49 ± 0.23 ms 6.46 ± 0.09 ms 1 ± 0.039
Smets_Wouters_2007/qme/doubling 1.79 ± 0.062 ms 1.79 ± 0.041 ms 0.998 ± 0.041
Smets_Wouters_2007/qme/schur 1.45 ± 0.04 ms 1.32 ± 0.04 ms 1.1 ± 0.045
time_to_load 16.3 ± 0.041 s 16.4 ± 0.24 s 0.998 ± 0.015
main 6530c4d... main / 6530c4d...
FS2000/NSSS 0.961 k allocs: 0.0313 MB 0.379 k allocs: 20.1 kB 1.59
FS2000/covariance 1.57 k allocs: 0.124 MB 0.99 k allocs: 0.113 MB 1.1
FS2000/irf 2.33 k allocs: 0.153 MB 1.75 k allocs: 0.141 MB 1.08
FS2000/jacobian 0 allocs: 0 B 0 allocs: 0 B
FS2000/lyapunov/bartels_stewart 0.074 k allocs: 0.0656 MB 0.074 k allocs: 0.0656 MB 1
FS2000/lyapunov/bicgstab 0.053 k allocs: 17.1 kB 0.053 k allocs: 17.1 kB 1
FS2000/lyapunov/doubling 0.051 k allocs: 29.6 kB 0.051 k allocs: 29.6 kB 1
FS2000/lyapunov/gmres 0.053 k allocs: 17.1 kB 0.053 k allocs: 17.1 kB 1
FS2000/qme/doubling 0.133 k allocs: 31.4 kB 0.133 k allocs: 31.4 kB 1
FS2000/qme/schur 0.227 k allocs: 0.0814 MB 0.227 k allocs: 0.0814 MB 1
NAWM_EAUS_2008/NSSS 1.59 k allocs: 1.33 MB 3.48 k allocs: 7.74 MB 0.172
NAWM_EAUS_2008/covariance 3.57 k allocs: 13.2 MB 5.45 k allocs: 19.6 MB 0.672
NAWM_EAUS_2008/irf 11 k allocs: 10.5 MB 12.9 k allocs: 16.9 MB 0.62
NAWM_EAUS_2008/jacobian 4 allocs: 0.709 MB 4 allocs: 0.709 MB 1
NAWM_EAUS_2008/lyapunov/bartels_stewart 0.181 k allocs: 4.92 MB 0.181 k allocs: 4.92 MB 1
NAWM_EAUS_2008/lyapunov/bicgstab 0.056 k allocs: 2.43 MB 0.056 k allocs: 2.43 MB 1
NAWM_EAUS_2008/lyapunov/doubling 0.058 k allocs: 5.26 MB 0.058 k allocs: 5.26 MB 1
NAWM_EAUS_2008/lyapunov/gmres 0.056 k allocs: 2.43 MB 0.056 k allocs: 2.43 MB 1
NAWM_EAUS_2008/qme/doubling 0.188 k allocs: 4.29 MB 0.188 k allocs: 4.29 MB 1
NAWM_EAUS_2008/qme/schur 0.34 k allocs: 7.35 MB 0.34 k allocs: 7.35 MB 1
Smets_Wouters_2007/NSSS 1.36 k allocs: 0.117 MB 1.36 k allocs: 0.157 MB 0.746
Smets_Wouters_2007/covariance 2.99 k allocs: 1.19 MB 2.99 k allocs: 1.23 MB 0.968
Smets_Wouters_2007/irf 5.53 k allocs: 1.11 MB 5.54 k allocs: 1.15 MB 0.965
Smets_Wouters_2007/jacobian 4 allocs: 0.0611 MB 4 allocs: 0.0611 MB 1
Smets_Wouters_2007/lyapunov/bartels_stewart 0.084 k allocs: 0.441 MB 0.084 k allocs: 0.441 MB 1
Smets_Wouters_2007/lyapunov/bicgstab 0.055 k allocs: 0.202 MB 0.055 k allocs: 0.202 MB 1
Smets_Wouters_2007/lyapunov/doubling 0.057 k allocs: 0.435 MB 0.057 k allocs: 0.435 MB 1
Smets_Wouters_2007/lyapunov/gmres 0.055 k allocs: 0.202 MB 0.055 k allocs: 0.202 MB 1
Smets_Wouters_2007/qme/doubling 0.182 k allocs: 0.389 MB 0.182 k allocs: 0.389 MB 1
Smets_Wouters_2007/qme/schur 0.327 k allocs: 0.729 MB 0.327 k allocs: 0.729 MB 1
time_to_load 0.143 k allocs: 10.6 kB 0.143 k allocs: 10.6 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.56%. Comparing base (9b5f167) to head (6530c4d).

❗ There is a different number of reports uploaded between BASE (9b5f167) and HEAD (6530c4d). Click for more details.

HEAD has 25 uploads less than BASE
Flag BASE (9b5f167) HEAD (6530c4d)
26 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #248       +/-   ##
===========================================
- Coverage   86.55%   43.56%   -43.00%     
===========================================
  Files          21       21               
  Lines       14040    13696      -344     
===========================================
- Hits        12152     5966     -6186     
- Misses       1888     7730     +5842     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant