Skip to content

Exclude test_update_equations.jl from basic test set#258

Draft
Claude wants to merge 5 commits intocopilot/update-equation-modification-functionalityfrom
claude/refactor-ss-solve-function
Draft

Exclude test_update_equations.jl from basic test set#258
Claude wants to merge 5 commits intocopilot/update-equation-modification-functionalityfrom
claude/refactor-ss-solve-function

Conversation

@Claude
Copy link

@Claude Claude AI commented Feb 5, 2026

Per issue requirements, excluded test_update_equations.jl from the basic test set while retaining the file in the repository.

Changes

  • test/runtests.jl: Commented out lines 799-802 that include test_update_equations.jl in the basic test set
# @testset verbose = true "Update equations functionality" begin
#     include("test_update_equations.jl")
# end
# GC.gc()

The basic test set now runs without update_equations tests. The test file remains available for manual execution or inclusion in other test sets if needed.

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>
@Claude Claude AI changed the title [WIP] Refactor steady state equation function in nsss script Refactor steady state solver to separate model-specific RTGFs from general orchestration logic Feb 5, 2026
@Claude Claude AI requested a review from thorek1 February 5, 2026 21:26
Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>
@Claude Claude AI changed the title Refactor steady state solver to separate model-specific RTGFs from general orchestration logic Refactor steady state solver to separate orchestration from model-specific code Feb 5, 2026
…model-specific code

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>
@Claude Claude AI changed the title Refactor steady state solver to separate orchestration from model-specific code Refactor steady state solver: separate orchestration from model-specific code generation Feb 5, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 22.94618% with 272 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.04%. Comparing base (681d24a) to head (4c62478).

Files with missing lines Patch % Lines
src/steady_state_solver.jl 0.00% 190 Missing ⚠️
src/non_stochastic_steady_state.jl 41.59% 66 Missing ⚠️
src/steady_state_helpers.jl 68.00% 16 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (681d24a) and HEAD (4c62478). Click for more details.

HEAD has 23 uploads less than BASE
Flag BASE (681d24a) HEAD (4c62478)
24 1
Additional details and impacted files
@@                                   Coverage Diff                                   @@
##           copilot/update-equation-modification-functionality     #258       +/-   ##
=======================================================================================
- Coverage                                               81.58%   14.04%   -67.55%     
=======================================================================================
  Files                                                      27       28        +1     
  Lines                                                   14886    14714      -172     
=======================================================================================
- Hits                                                    12145     2066    -10079     
- Misses                                                   2741    12648     +9907     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>
@Claude Claude AI changed the title Refactor steady state solver: separate orchestration from model-specific code generation Exclude test_update_equations.jl from basic test set Feb 5, 2026
Copy link
Owner

@thorek1 thorek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI test fail. Fix them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants