Improve theme readability and persistence in SplashKit Online#151
Open
liammcknightt wants to merge 1 commit into
Open
Improve theme readability and persistence in SplashKit Online#151liammcknightt wants to merge 1 commit into
liammcknightt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change improved the contrast and readability of the available themes in SplashKit Online, it also fixed a persistence bug where a selected theme would reset to default if the page was refreshed, a project was loaded/changed or different language was selected.
Fixes # (issue)
Unreadable and non-persistence themes.
Type of change
How Has This Been Tested?
I tested in all three browsers that the themes look readable and behave the same.
I cycled through selecting different languages, selecting different projects, closing opening things and refreshing the page to ensure the theme stayed the same until I switched to a different one.
Testing Checklist
Checklist