feat: migrate vendor-dependencies from CoffeeScript to TypeScript#458
feat: migrate vendor-dependencies from CoffeeScript to TypeScript#458sakethsram8888 wants to merge 2 commits into
Conversation
millyamolo
left a comment
There was a problem hiding this comment.
This is a solid step toward improving maintainability and supporting the ongoing migration effort. The structure looks clean and uses proper import/export syntax, and the dependencies are clearly defined and easy to follow. From basic testing, the application runs as expected (login works, no console errors, UI loads correctly), so the change appears non-breaking. One minor note is that it still uses angular.module(...), which is expected given the current hybrid AngularJS setup, and it may be worth confirming that any previous CoffeeScript implementation has been fully removed and that no dependencies were missed. Overall, this looks good to me and I’m happy to approve.
Sujay-Deakin
left a comment
There was a problem hiding this comment.
Tested this locally, and the app loads as expected, no issues with the vendor dependencies being picked up after the migration. The conversion itself is clean and straightforward. All the third-party dependencies are preserved as-is, the import in doubtfire-angularjs.module.ts now correctly points to the TypeScript source rather than the compiled build output, and the change is nicely scoped with no unrelated files touched.
Happy to approve this.
sheshankarvapally
left a comment
There was a problem hiding this comment.
Reviewed and tested locally on the review/pr-458 branch.
Verified that the application builds and runs successfully with the migrated vendor-dependencies.ts implementation. Login flow, dashboard loading, and general navigation all work as expected with no visible UI issues or console errors during testing.
Changes appear clean and limited to the intended vendor dependency migration scope.
Description
Migrates the vendor-dependencies module from CoffeeScript (AngularJS) to TypeScript (Angular 17).
The file
vendor-dependencies.coffeehas been rewritten asvendor-dependencies.ts, converting the AngularJS module definition to TypeScript while preserving all existing third-party dependencies.The import in
doubtfire-angularjs.module.tshas been updated to reference the new TypeScript file directly instead of the compiled JavaScript build output.Fixes # (issue)
Type of change
How Has This Been Tested?
The application was tested locally at localhost:4200. The app loads correctly and login functionality works as expected with the new TypeScript file in place of the old CoffeeScript file.
Testing Checklist:
Checklist:
old .coffee file

new .ts file

localhost working
