Investigate config module dependencies and clean up legacy root-controller usage#464
Conversation
WaelAlahamdi
left a comment
There was a problem hiding this comment.
Hi @sheshankarvapally,
Reviewed and tested locally.
The application loads correctly, navigation works as expected, and no console/runtime errors were encountered during testing.
The migration cleanup and legacy CoffeeScript dependency removal align with the task objectives. Looks good to me.
Sujay-Deakin
left a comment
There was a problem hiding this comment.
Tested this locally, good to see the bundle still generates cleanly with those four CoffeeScript config files removed. The cleanup is well-scoped, and the wrapper being stripped out is a nice step forward in the migration. Looks good to me.
sakethsram8888
left a comment
There was a problem hiding this comment.
Tested this PR on my local machine and everything worked as expected. The migration cleanup looks solid, and I didn’t encounter any issues related to the removed config layer or AppCtrl changes. The application loaded successfully and the bundle generation completed without errors.
I also appreciate the investigation and simplification of the legacy AngularJS config dependency area ,the changes make the migration path much cleaner and easier to maintain.
Summary:
This PR continues Task 2 by migrating the legacy AngularJS config dependency area away from CoffeeScript as part of the Angular 17 migration effort.
Changes made:
Removed config.coffee
Removed root-controller.coffee because AppCtrl had no functional logic
Removed routing.coffee
Removed runtime.coffee
Removed dependency on the old doubtfire.config module
Updated index.html to remove AppCtrl usage
Kept required config submodules such as:
Investigation Findings:
Testing: